Re: RFC: PATCH to adjust warning flags for C++

2011-11-02 Thread Paolo Bonzini
On 11/01/2011 06:54 PM, Jason Merrill wrote: Paolo Carlini's patch to add -Wnarrowing to -Wc++0x-compat (and thus -Wall) broke bootstrap because of narrowing warnings, so I'd like to add -Wno-narrowing to the stage 2+ warning flags. Is this the best way to do that? Is this a C++-only warning?

Re: RFC: PATCH to adjust warning flags for C++

2011-11-02 Thread Gabriel Dos Reis
On Wed, Nov 2, 2011 at 12:40 AM, Jason Merrill ja...@redhat.com wrote: On 11/02/2011 12:05 AM, Gabriel Dos Reis wrote:  And I think that your code won't work in C++11 is a warning that most C++ programmers will be interested in if they are asking for warnings. Even when -std=c++03 -Wall or

Re: RFC: PATCH to adjust warning flags for C++

2011-11-02 Thread Jason Merrill
On 11/02/2011 05:40 AM, Paolo Bonzini wrote: Is this a C++-only warning? Also, how did you test the patch? It is, but the flag is accepted and ignored by the C front end. I tested it with a bootstrap. Jason

Re: RFC: PATCH to adjust warning flags for C++

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 02:47 PM, Jason Merrill wrote: Is this a C++-only warning? Also, how did you test the patch? It is, but the flag is accepted and ignored by the C front end. Then please adjust libcpp/configure.ac too; otherwise the patch is okay to fix bootstrap. It can be reverted later if

Re: RFC: PATCH to adjust warning flags for C++

2011-11-01 Thread Gabriel Dos Reis
On Tue, Nov 1, 2011 at 12:54 PM, Jason Merrill ja...@redhat.com wrote: Paolo Carlini's patch to add -Wnarrowing to -Wc++0x-compat (and thus -Wall) broke bootstrap because of narrowing warnings, so I'd like to add -Wno-narrowing to the stage 2+ warning flags.  Is this the best way to do that?

Re: RFC: PATCH to adjust warning flags for C++

2011-11-01 Thread Jason Merrill
On 11/01/2011 03:48 PM, Gabriel Dos Reis wrote: On Tue, Nov 1, 2011 at 12:54 PM, Jason Merrillja...@redhat.com wrote: Paolo Carlini's patch to add -Wnarrowing to -Wc++0x-compat (and thus -Wall) broke bootstrap because of narrowing warnings, so I'd like to add -Wno-narrowing to the stage 2+

Re: RFC: PATCH to adjust warning flags for C++

2011-11-01 Thread Gabriel Dos Reis
On Tue, Nov 1, 2011 at 8:11 PM, Jason Merrill ja...@redhat.com wrote: On 11/01/2011 03:48 PM, Gabriel Dos Reis wrote: On Tue, Nov 1, 2011 at 12:54 PM, Jason Merrillja...@redhat.com  wrote: Paolo Carlini's patch to add -Wnarrowing to -Wc++0x-compat (and thus -Wall) broke bootstrap because of

Re: RFC: PATCH to adjust warning flags for C++

2011-11-01 Thread Jason Merrill
On 11/02/2011 12:05 AM, Gabriel Dos Reis wrote: And I think that your code won't work in C++11 is a warning that most C++ programmers will be interested in if they are asking for warnings. Even when -std=c++03 -Wall or -std=c++98 -Wall? Yes. -Wc++0x-compat has been part of -Wall for