Re: RFC: add some static probes to libstdc++

2013-04-09 Thread Tom Tromey
Jonathan == Jonathan Wakely jwakely@gmail.com writes: Marc I thought you were going to suggest enhancing the configure test Marc so it fails on old systemtap (detects it as absent). Jonathan Ah yes, that's a much better idea! Here's a patch to do that. I tested it on x86-64 Fedora 18. I

Re: RFC: add some static probes to libstdc++

2013-04-09 Thread Jonathan Wakely
On 9 April 2013 18:47, Tom Tromey wrote: Jonathan == Jonathan Wakely jwakely@gmail.com writes: Marc I thought you were going to suggest enhancing the configure test Marc so it fails on old systemtap (detects it as absent). Jonathan Ah yes, that's a much better idea! Here's a patch to

Re: RFC: add some static probes to libstdc++

2013-04-08 Thread Tom Tromey
Jonathan == Jonathan Wakely jwakely@gmail.com writes: Jonathan On 2 April 2013 16:39, Marc Glisse wrote: On Tue, 2 Apr 2013, Jonathan Wakely wrote: Should we update the prerequisites documentation to say that if Systemtap is installed it needs to be at least version X? I thought you

Re: RFC: add some static probes to libstdc++

2013-04-02 Thread Jonathan Wakely
On 15 March 2013 08:55, Jakub Jelinek ja...@redhat.com wrote: On Thu, Feb 28, 2013 at 08:32:02AM -0700, Tom Tromey wrote: 2013-02-27 Tom Tromey tro...@redhat.com * libsupc++/unwind-cxx.h: Include sys/sdt.h if detected. (PROBE2): New macro. * libsupc++/eh_throw.cc

Re: RFC: add some static probes to libstdc++

2013-04-02 Thread Marc Glisse
On Tue, 2 Apr 2013, Jonathan Wakely wrote: On 15 March 2013 08:55, Jakub Jelinek ja...@redhat.com wrote: On Thu, Feb 28, 2013 at 08:32:02AM -0700, Tom Tromey wrote: 2013-02-27 Tom Tromey tro...@redhat.com * libsupc++/unwind-cxx.h: Include sys/sdt.h if detected. (PROBE2): New

Re: RFC: add some static probes to libstdc++

2013-04-02 Thread Jonathan Wakely
On 2 April 2013 16:39, Marc Glisse wrote: On Tue, 2 Apr 2013, Jonathan Wakely wrote: Should we update the prerequisites documentation to say that if Systemtap is installed it needs to be at least version X? I thought you were going to suggest enhancing the configure test so it fails on old

Re: RFC: add some static probes to libstdc++

2013-03-15 Thread Jakub Jelinek
On Thu, Feb 28, 2013 at 08:32:02AM -0700, Tom Tromey wrote: 2013-02-27 Tom Tromey tro...@redhat.com * libsupc++/unwind-cxx.h: Include sys/sdt.h if detected. (PROBE2): New macro. * libsupc++/eh_throw.cc (__cxa_throw, __cxa_rethrow): Add probe. *

Re: RFC: add some static probes to libstdc++

2013-03-14 Thread Tom Tromey
Tom 2013-02-27 Tom Tromey tro...@redhat.com Tom* libsupc++/unwind-cxx.h: Include sys/sdt.h if detected. Tom(PROBE2): New macro. Tom* libsupc++/eh_throw.cc (__cxa_throw, __cxa_rethrow): Add probe. Tom* libsupc++/eh_catch.cc (__cxa_begin_catch): Add probe. Tom* configure.ac:

Re: RFC: add some static probes to libstdc++

2013-02-28 Thread Dave Korn
On 27/02/2013 21:52, Tom Tromey wrote: I'm posting this now to get reactions to the probe before cleaning up the corresponding gdb patches for submission. I've built it both with and without sys/sdt.h, but I haven't yet run the test suite. How did it build in the without sys/sdt.h case?

Re: RFC: add some static probes to libstdc++

2013-02-28 Thread Tom Tromey
Dave == Dave Korn dave.korn.cyg...@gmail.com writes: Dave How did it build in the without sys/sdt.h case? Dave Without HAVE_SYS_SDT_H, there's no definition of PROBE2 at all, Dave but you use it unconditionally in eh_{catch,throw}.cc. Am I Dave missing something? Ugh. I must have made some

Re: RFC: add some static probes to libstdc++

2013-02-28 Thread Tom Tromey
Dave How did it build in the without sys/sdt.h case? Sorry about that again. I must have made some change after testing it. Here is an updated version. One thing I found out while fixing this up is that changes to unwind-cxx.h do not cause anything to rebuild if I just run make. I have to

RFC: add some static probes to libstdc++

2013-02-27 Thread Tom Tromey
I've been working a bit on improving exception-related features in gdb. I had two goals which led to this particular patch. First, I wanted to be able to implement type-name-based filtering for catch catch and friends. (This feature was documented in the past, but never implemented, and