Re: RFC (DECL_CONSTRUCTOR_P): C++ PATCH for c++/83911, ICE with multiversioned constructor

2018-02-17 Thread Nathan Sidwell
On 02/16/2018 05:48 PM, Jason Merrill wrote: We hit the bug in this testcase because build_over_call replaces the constructor with a dispatcher function, and then build_aggr_init_expr doesn't recognize it as a constructor. Messing with the DECL_NAME of the dispatcher seems messy, but copying

Re: RFC (DECL_CONSTRUCTOR_P): C++ PATCH for c++/83911, ICE with multiversioned constructor

2018-02-16 Thread Nathan Sidwell
On 02/16/2018 05:48 PM, Jason Merrill wrote: We hit the bug in this testcase because build_over_call replaces the constructor with a dispatcher function, and then build_aggr_init_expr doesn't recognize it as a constructor. Messing with the DECL_NAME of the dispatcher seems messy, but copying

RFC (DECL_CONSTRUCTOR_P): C++ PATCH for c++/83911, ICE with multiversioned constructor

2018-02-16 Thread Jason Merrill
We hit the bug in this testcase because build_over_call replaces the constructor with a dispatcher function, and then build_aggr_init_expr doesn't recognize it as a constructor. Messing with the DECL_NAME of the dispatcher seems messy, but copying the DECL_CXX_CONSTRUCTOR_P flag is easy. So we