On 2/18/19 8:34 PM, Jason Merrill wrote:
> Fixed thus:
Works for me, thanks!
Martin
On 2/18/19 7:44 AM, Martin Liška wrote:
PING^1
On 11/30/18 11:26 AM, Martin Liška wrote:
Hi Jason.
Just small nits I noticed for:
cat test4.C
int a, b, c;
void
__attribute__((noinline))
bar()
{
if (a == 123)
[[likely]] c = 5;
else
[[likely]] b = 77;
}
int main()
{
bar ();
PING^1
On 11/30/18 11:26 AM, Martin Liška wrote:
> Hi Jason.
>
> Just small nits I noticed for:
>
> cat test4.C
> int a, b, c;
>
> void
> __attribute__((noinline))
> bar()
> {
> if (a == 123)
> [[likely]] c = 5;
> else
> [[likely]] b = 77;
> }
>
> int main()
> {
> bar ();
> ret
Hi Jason.
Just small nits I noticed for:
cat test4.C
int a, b, c;
void
__attribute__((noinline))
bar()
{
if (a == 123)
[[likely]] c = 5;
else
[[likely]] b = 77;
}
int main()
{
bar ();
return 0;
}
$ g++ test4.C -c
test4.C: In function ‘void bar()’:
test4.C:8:16: warning: both br
> On Thu, Nov 15, 2018 at 7:14 AM Jan Hubicka wrote:
> >
> > > > A warning seems appropriate. You think the front end is the right
> > > > place for that?
> > >
> > > Probably yes. Note that middle-end can optimize about dead branches and
> > > so that
> > > theoretically one can end up with a b
On Thu, Nov 15, 2018 at 7:14 AM Jan Hubicka wrote:
>
> > > A warning seems appropriate. You think the front end is the right
> > > place for that?
> >
> > Probably yes. Note that middle-end can optimize about dead branches and so
> > that
> > theoretically one can end up with a branching where e
> > A warning seems appropriate. You think the front end is the right
> > place for that?
>
> Probably yes. Note that middle-end can optimize about dead branches and so
> that
> theoretically one can end up with a branching where e.g. both branches are
> [[likely]].
> I wouldn't bother users wi
On 11/13/18 8:42 PM, Jason Merrill wrote:
> On Tue, Nov 13, 2018 at 9:20 AM Martin Liška wrote:
>>
>> On 11/13/18 5:43 AM, Jason Merrill wrote:
>>> [[likely]] and [[unlikely]] are equivalent to the GNU hot/cold attributes,
>>> except that they can be applied to arbitrary statements as well as labe
On Tue, Nov 13, 2018 at 9:20 AM Martin Liška wrote:
>
> On 11/13/18 5:43 AM, Jason Merrill wrote:
> > [[likely]] and [[unlikely]] are equivalent to the GNU hot/cold attributes,
> > except that they can be applied to arbitrary statements as well as labels;
> > this is most likely to be useful for m
On 11/13/18 5:43 AM, Jason Merrill wrote:
> [[likely]] and [[unlikely]] are equivalent to the GNU hot/cold attributes,
> except that they can be applied to arbitrary statements as well as labels;
> this is most likely to be useful for marking if/else branches as likely or
> unlikely. Conveniently,
[[likely]] and [[unlikely]] are equivalent to the GNU hot/cold attributes,
except that they can be applied to arbitrary statements as well as labels;
this is most likely to be useful for marking if/else branches as likely or
unlikely. Conveniently, PREDICT_EXPR fits the bill nicely as a
representa
11 matches
Mail list logo
