Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-23 Thread Rainer Orth
Hi Arnaud, >> I'd keep the target list alphabetical. Can do so when the Solaris patch >> goes in. >> >> Here's what I've successfully tested last night on both >> i386-pc-solaris2.11 and sparc-sun-solaris2.11, shamelessly stolen from >> the Linux counterparts. If it is acceptable, I'd add *-*-s

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-20 Thread Arnaud Charlet
> I'd keep the target list alphabetical. Can do so when the Solaris patch > goes in. > > Here's what I've successfully tested last night on both > i386-pc-solaris2.11 and sparc-sun-solaris2.11, shamelessly stolen from > the Linux counterparts. If it is acceptable, I'd add *-*-solaris2.* to > the

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-20 Thread Rainer Orth
Hi Olivier, >> On 19 Sep 2019, at 18:40, Olivier Hainque wrote: > Given that the test cannot compile on anything but *-*-linux* and *-*-mingw*, I'd rather restrict the test to those two (or more targets that decide to implement the missing interface). > >> Works for me as well. > [

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-20 Thread Rainer Orth
Hi Iain, >> On 19 Sep 2019, at 15:51, Rainer Orth wrote: >> > On 18 Sep 2019, at 09:39, Pierre-Marie de Rodat wrote: >>> gcc/testsuite/ * gnat.dg/system_info1.adb: New testcase. >>> >>> This new test fails everywhere on Darwin, which doesn’t have an >>> imp

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-20 Thread Olivier Hainque
Hello Iain & Rainer, > On 19 Sep 2019, at 18:40, Olivier Hainque wrote: >>> Given that the test cannot compile on anything but *-*-linux* and >>> *-*-mingw*, I'd rather restrict the test to those two (or more targets >>> that decide to implement the missing interface). > Works for me as well. [

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-19 Thread Olivier Hainque
Hello Iain & Rainer, Thanks for the heads up and sorry for the disruption from this one. > On 19 Sep 2019, at 17:02, Iain Sandoe wrote: > >> Given that the test cannot compile on anything but *-*-linux* and >> *-*-mingw*, I'd rather restrict the test to those two (or more targets >> that decide

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-19 Thread Iain Sandoe
Hi Rainer, > On 19 Sep 2019, at 15:51, Rainer Orth wrote: > >>> On 18 Sep 2019, at 09:39, Pierre-Marie de Rodat wrote: >>> >> >>> gcc/testsuite/ >>> >>> * gnat.dg/system_info1.adb: New testcase. >> >> This new test fails everywhere on Darwin, which doesn’t have an >> implementation fo

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-19 Thread Rainer Orth
Hi Iain, >> On 18 Sep 2019, at 09:39, Pierre-Marie de Rodat wrote: >> > >> gcc/testsuite/ >> >> * gnat.dg/system_info1.adb: New testcase. > > This new test fails everywhere on Darwin, which doesn’t have an > implementation for > System.Task_Info.Number_Of_Processors > > Given > "pragma O

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

2019-09-19 Thread Iain Sandoe
Hi Folks, > On 18 Sep 2019, at 09:39, Pierre-Marie de Rodat wrote: > > gcc/testsuite/ > > * gnat.dg/system_info1.adb: New testcase. This new test fails everywhere on Darwin, which doesn’t have an implementation for System.Task_Info.Number_Of_Processors Given "pragma Obsolescent (Task