Re: [C++ Patch] Another bunch of location fixes

2019-09-16 Thread Jason Merrill
On Mon, Sep 16, 2019 at 5:22 AM Paolo Carlini wrote: > > On 15/09/19 16:22, Jason Merrill wrote: > > On 9/12/19 9:41 AM, Paolo Carlini wrote: > >> + if (!valid_array_size_p (dname > >> + ? declarator->id_loc : input_location, > > > > Use the id_loc local variable? > > This d

Re: [C++ Patch] Another bunch of location fixes

2019-09-16 Thread Paolo Carlini
Hi, On 15/09/19 16:22, Jason Merrill wrote: On 9/12/19 9:41 AM, Paolo Carlini wrote: +  if (!valid_array_size_p (dname +   ? declarator->id_loc : input_location, Use the id_loc local variable? This diagnostic is inside the loop over declarator->declarator. Eventually, o

Re: [C++ Patch] Another bunch of location fixes

2019-09-15 Thread Jason Merrill
On 9/12/19 9:41 AM, Paolo Carlini wrote: + if (!valid_array_size_p (dname + ? declarator->id_loc : input_location, Use the id_loc local variable? OK with that change. Jason

Re: [C++ Patch] Another bunch of location fixes for decl.c/decl2.c functions

2018-06-14 Thread Jason Merrill
OK. On Thu, Jun 14, 2018 at 10:48 AM, Paolo Carlini wrote: > Hi, > > tested x86_64 linux. > > Thanks, Paolo. > > /// >