Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns, 2/3

2011-04-15 Thread Richard Earnshaw
On Thu, 2011-04-14 at 21:19 +0800, Carrot Wei wrote: On Fri, Apr 8, 2011 at 6:51 PM, Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: On 08/04/11 10:57, Carrot Wei wrote: Hi This is the second part of the fixing for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47855

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns, 2/3

2011-04-15 Thread Carrot Wei
Hi Richard Thank you for the detailed explanation. It sounds like an inherent difficulty of rtl passes. Then the only opportunity is ldrb/strb instructions because they never affect cc registers. thanks Carrot On Fri, Apr 15, 2011 at 9:34 PM, Richard Earnshaw rearn...@arm.com wrote: On Thu,

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-04-08 Thread Carrot Wei
Hi This patch moves the length computation of push_multi into a C function to avoid the usage of GNU extension. Tested on qemu without regression. OK to install? thanks Carrot ChangeLog: 2011-04-08 Wei Guozhi car...@google.com PR target/47855 * config/arm/arm-protos.h

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-04-07 Thread Carrot Wei
On Thu, Apr 7, 2011 at 5:31 PM, Richard Sandiford richard.sandif...@linaro.org wrote: Hi Carrot, Sorry if this has already been reported, but the patch breaks bootstrap of arm-linux-gnueabi (or cross builds with --enable-werror).  The problem is that this... uses a statement expression --

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-04-07 Thread Ramana Radhakrishnan
On 07/04/11 12:08, Carrot Wei wrote: On Thu, Apr 7, 2011 at 5:31 PM, Richard Sandiford richard.sandif...@linaro.org wrote: Hi Carrot, Sorry if this has already been reported, but the patch breaks bootstrap of arm-linux-gnueabi (or cross builds with --enable-werror). The problem is that

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-04-05 Thread Ramana Radhakrishnan
The patch was tested on arm qemu without regression, OK for install? Ok if no regressions. cheers Ramana thanks Carrot ChangeLog: 2011-04-01 Wei Guozhicar...@google.com PR target/47855 * config/arm/arm.md (arm_cmpsi_insn): Compute attr length.

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-03-31 Thread Ramana Radhakrishnan
Hi Carrot, How about adding an alternative only enabled for T2 that uses the `l' constraint and inventing new constraints for some of the constant values that are valid for 16 bit instructions since the `I' and `L' constraints have different meanings depending on whether TARGET_32BIT

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-03-30 Thread Richard Earnshaw
On Wed, 2011-03-30 at 12:38 +0800, Chung-Lin Tang wrote: On 2011/3/30 06:35 AM, Ramana Radhakrishnan wrote: Hi Carrot, On 26/03/11 15:14, Carrot Wei wrote: Index: arm.md === --- arm.md(revision 171337) +++ arm.md

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-03-30 Thread Carrot Wei
Hi Ramana On Wed, Mar 30, 2011 at 6:35 AM, Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: Hi Carrot,        How about adding an alternative only enabled for T2 that uses the `l' constraint and inventing new constraints for some of the constant values that are valid for 16 bit

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-03-29 Thread Ramana Radhakrishnan
Hi Carrot, On 26/03/11 15:14, Carrot Wei wrote: Index: arm.md === --- arm.md (revision 171337) +++ arm.md (working copy) @@ -7115,7 +7115,18 @@ @ cmp%?\\t%0, %1 cmn%?\\t%0, #%n1 - [(set_attr conds set)] +

Re: [PATCH, ARM] PR47855 Compute attr length for some thumb2 insns

2011-03-29 Thread Chung-Lin Tang
On 2011/3/30 06:35 AM, Ramana Radhakrishnan wrote: Hi Carrot, On 26/03/11 15:14, Carrot Wei wrote: Index: arm.md === --- arm.md(revision 171337) +++ arm.md(working copy) @@ -7115,7 +7115,18 @@ @ cmp%?\\t%0,