Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-08-14 Thread Kirill Yukhin
OK, provided that the patches in the above threads apply without conflicts. If there are conflicts, please repost for review. Comitted to 4.7 branch: http://gcc.gnu.org/ml/gcc-cvs/2012-08/msg00360.html Thanks, K

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-08-10 Thread Igor Zamyatin
Hi! There were only trivial merge conflicts like [(match_operand 0 memory_operand ) (match_operand 1 memory_operand )] --- [(match_operand 0 memory_operand) (match_operand 1 memory_operand)] !TARGET_HAS_BIONIC Patch attached. All necessary testing passed. Ok for 4.7?

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-08-08 Thread Igor Zamyatin
Hi all! I'd like to ask whether stack-protector changes for Android could go to 4.7? Pathes are: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01089.html http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01157.html Thanks, Igor On Wed, Jul 25, 2012 at 2:08 AM, Maxim Kuvyrkov ma...@codesourcery.com

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-08-08 Thread Uros Bizjak
On Wed, Aug 8, 2012 at 9:54 AM, Igor Zamyatin izamya...@gmail.com wrote: I'd like to ask whether stack-protector changes for Android could go to 4.7? Pathes are: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01089.html http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01157.html OK, as far as

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-08-08 Thread Maxim Kuvyrkov
On 8/08/2012, at 9:46 PM, Uros Bizjak wrote: On Wed, Aug 8, 2012 at 9:54 AM, Igor Zamyatin izamya...@gmail.com wrote: I'd like to ask whether stack-protector changes for Android could go to 4.7? Pathes are: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01089.html

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-24 Thread Uros Bizjak
On Mon, Jul 23, 2012 at 10:00 PM, Igor Zamyatin izamya...@gmail.com wrote: 2012-07-23 Sergey Melnikov sergey.melni...@intel.com * config/i386/i386.md (stack_protect_set): Disable the pattern for Android since Android libc (bionic) does not provide random value for

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-24 Thread Maxim Kuvyrkov
On 24/07/2012, at 10:08 PM, Uros Bizjak wrote: On Mon, Jul 23, 2012 at 10:00 PM, Igor Zamyatin izamya...@gmail.com wrote: 2012-07-23 Sergey Melnikov sergey.melni...@intel.com * config/i386/i386.md (stack_protect_set): Disable the pattern for Android since Android libc

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-16 Thread Rainer Emrich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm not sure if that's related, but for x86_64-w64-mingw32 bootstrap fails in stage 1: gcc -c -g -DIN_GCC -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual - -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wc++-compat -

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-16 Thread Kai Tietz
Hi, I would kindly ask to revert this patch soonish. The define OPTION_BIONIC is defined within linux.h header, which isn't used by cygwin and mingw targets. so this symbol is undefined for them and this is causing bootstrap issue for cygwin and mingw targets. Regards, Kai

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-16 Thread Kirill Yukhin
Reverted. http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00442.html Thanks, K On Mon, Jul 16, 2012 at 5:36 PM, Kai Tietz ktiet...@googlemail.com wrote: Hi, I would kindly ask to revert this patch soonish. The define OPTION_BIONIC is defined within linux.h header, which isn't used by cygwin and

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-09 Thread Maxim Kuvyrkov
On 10/07/2012, at 8:51 AM, Igor Zamyatin wrote: Let's try with this patch then. Is it ok for trunk after all appropriate testing is done? Sorry for the late reply, I've been down with a virus last week. Uros, Would you please approve this patch for i386 provided my review below?

Re: [PATCH, Android] Runtime stack protector enabling for Android target

2012-07-06 Thread Igor Zamyatin
Right, flag_android looks better, thanks. Probably it's even better to check also bionic (OPTION_BIONIC) On Fri, Jul 6, 2012 at 12:13 PM, Andrew Pinski pins...@gmail.com wrote: On Fri, Jul 6, 2012 at 12:49 AM, Igor Zamyatin izamya...@gmail.com wrote: Hi! For runtime stack protector enabling