Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2013-06-24 Thread Dodji Seketeli
this thing quickly so that the build doesn't break on newer versions of libxml2. Cheers. From: Andrew Haley a...@redhat.com Subject: Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer To: Dodji Seketeli do...@redhat.com Date: Thu, 09 Aug 2012 10:06:13 +0100 (45 weeks, 3 days, 22

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2013-06-24 Thread Andrew Haley
On 06/24/2013 09:13 AM, Dodji Seketeli wrote: Just to make sure I understand what you are saying; do you mean that the accessor macro GET_XML_OUTPUT_BUFFER_SIZE (that depends on LIBXML2_NEW_BUFFER) shouldn't be defined in libjava/classpath/native/jni/xmlj/xmlj_io.c but somewhere else by an

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2013-06-21 Thread Andrew Haley
On 08/08/2012 11:08 PM, Dodji Seketeli wrote: OK to commit? Looks good, but what sets LIBXML2_NEW_BUFFER ? Andrew.

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2013-06-21 Thread Daniel Veillard
On Fri, Jun 21, 2013 at 12:13:35PM +0100, Andrew Haley wrote: On 08/08/2012 11:08 PM, Dodji Seketeli wrote: OK to commit? Looks good, but what sets LIBXML2_NEW_BUFFER ? I lack context but I think I can answer that one :) LIBXML2_NEW_BUFFER is a libxml2 public macro from libxml/tree.h /*

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2013-06-21 Thread Andrew Haley
On 06/21/2013 12:19 PM, Daniel Veillard wrote: On Fri, Jun 21, 2013 at 12:13:35PM +0100, Andrew Haley wrote: On 08/08/2012 11:08 PM, Dodji Seketeli wrote: OK to commit? Looks good, but what sets LIBXML2_NEW_BUFFER ? I lack context but I think I can answer that one :)

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2012-08-09 Thread Dodji Seketeli
Andrew Hughes ahug...@redhat.com writes: OK. As this is a GNU Classpath change, it should go in there first to avoid creating a divergence which will cause later problems in merging. Classpath is regularly merged into gcj as a whole. I found several patches during the last merge

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2012-08-09 Thread Andrew Hughes
- Original Message - Andrew Hughes ahug...@redhat.com writes: OK. As this is a GNU Classpath change, it should go in there first to avoid creating a divergence which will cause later problems in merging. Classpath is regularly merged into gcj as a whole. I found

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2012-08-09 Thread Dodji Seketeli
Andrew Hughes ahug...@redhat.com writes: Don't worry about reverting it. I'll add it to Classpath now, then they'll be in sync when we do the next merge. Thank you. In future, please post changes to files under the libjava/classpath directory to classp...@gnu.org and feel free to ping me

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2012-08-09 Thread Andrew Hughes
- Original Message - Andrew Hughes ahug...@redhat.com writes: Don't worry about reverting it. I'll add it to Classpath now, then they'll be in sync when we do the next merge. Thank you. Done:

Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer

2012-08-08 Thread Daniel Veillard
On Thu, Aug 09, 2012 at 12:08:20AM +0200, Dodji Seketeli wrote: Hello, This is a fix to prepare the xmlj_io.c file of gnu classpath to a coming API change in libxml2. Basically, we were previously accessing fields inside the xmlOutputBuffer struct of libxml2. In a coming version of