Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-08-04 Thread James Greenhalgh
On Thu, Jul 16, 2015 at 10:24:20AM +0100, Szabolcs Nagy wrote: > On 06/07/15 11:24, James Greenhalgh wrote: > > > > Please make sure in a follow-up patch that the costing logic in > > aarch64_rtx_costs also gets updated. > > > > Tested with aarch64-none-linux-gnu cross compiler. > is this OK? T

Re: Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-08-04 Thread Szabolcs Nagy
On 16/07/15 10:24, Szabolcs Nagy wrote: On 06/07/15 11:24, James Greenhalgh wrote: Please make sure in a follow-up patch that the costing logic in aarch64_rtx_costs also gets updated. Tested with aarch64-none-linux-gnu cross compiler. is this OK? i assume i should backport the fnmul fixes t

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-16 Thread Szabolcs Nagy
On 06/07/15 11:24, James Greenhalgh wrote: > > Please make sure in a follow-up patch that the costing logic in > aarch64_rtx_costs also gets updated. > Tested with aarch64-none-linux-gnu cross compiler. is this OK? i assume i should backport the fnmul fixes to the gcc-5 branch. 2015-07-16 Sza

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-15 Thread Szabolcs Nagy
On 15/07/15 09:11, Ramana Radhakrishnan wrote: > On 09/07/15 15:40, Szabolcs Nagy wrote: >> On 06/07/15 16:39, Marcus Shawcroft wrote: >>> On 6 July 2015 at 09:20, Szabolcs Nagy wrote: >>> 2015-07-06 Szabolcs Nagy > > > PR target/66731 in Changelog ? > thanks, fixed in r225810.

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-15 Thread Ramana Radhakrishnan
On 09/07/15 15:40, Szabolcs Nagy wrote: > On 06/07/15 16:39, Marcus Shawcroft wrote: >> On 6 July 2015 at 09:20, Szabolcs Nagy wrote: >> >>> 2015-07-06 Szabolcs Nagy PR target/66731 in Changelog ? Ramana >>> >>> * gcc.target/aarch64/fnmul-1.c: New. >>> * gcc.target/aarch6

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-09 Thread Szabolcs Nagy
On 06/07/15 16:39, Marcus Shawcroft wrote: > On 6 July 2015 at 09:20, Szabolcs Nagy wrote: > >> 2015-07-06 Szabolcs Nagy >> >> * gcc.target/aarch64/fnmul-1.c: New. >> * gcc.target/aarch64/fnmul-2.c: New. >> * gcc.target/aarch64/fnmul-3.c: New. >> * gcc.target/aa

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-06 Thread Marcus Shawcroft
On 6 July 2015 at 09:20, Szabolcs Nagy wrote: > 2015-07-06 Szabolcs Nagy > > * gcc.target/aarch64/fnmul-1.c: New. > * gcc.target/aarch64/fnmul-2.c: New. > * gcc.target/aarch64/fnmul-3.c: New. > * gcc.target/aarch64/fnmul-4.c: New. +float +foo_s (float a, float

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-06 Thread James Greenhalgh
On Mon, Jul 06, 2015 at 09:20:39AM +0100, Szabolcs Nagy wrote: > fnmul was modeled as (-a)*b instead of -(a*b), which is wrong with > -frounding-math, so the correct pattern is added too and the other > one is only used if !flag_rounding_math. > > This affects a glibc math test, similar fix will b