Re: [PATCH][CilkPlus] Fix PR69363

2016-04-20 Thread Ilya Verbin
On Wed, Feb 17, 2016 at 15:46:00 +0100, Jakub Jelinek wrote: > On Wed, Feb 17, 2016 at 05:32:58PM +0300, Ilya Verbin wrote: > > This patch fixes > > Bootstrap and make check passed. OK for... stage 1? > > Ok for stage1, with a few nits.

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Marek Polacek
On Wed, Feb 17, 2016 at 04:14:22PM +0100, Jakub Jelinek wrote: > On Wed, Feb 17, 2016 at 04:11:44PM +0100, Marek Polacek wrote: > > On Wed, Feb 17, 2016 at 06:08:14PM +0300, Ilya Verbin wrote: > > > > This line is too long. But you could have just done > > > > > > My editor shows exactly 80

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Markus Trippelsdorf
On 2016.02.17 at 18:29 +0300, Ilya Verbin wrote: > On Wed, Feb 17, 2016 at 16:28:34 +0100, Marek Polacek wrote: > > On Wed, Feb 17, 2016 at 04:14:22PM +0100, Jakub Jelinek wrote: > > > On Wed, Feb 17, 2016 at 04:11:44PM +0100, Marek Polacek wrote: > > > > On Wed, Feb 17, 2016 at 06:08:14PM +0300,

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Ilya Verbin
On Wed, Feb 17, 2016 at 16:28:34 +0100, Marek Polacek wrote: > On Wed, Feb 17, 2016 at 04:14:22PM +0100, Jakub Jelinek wrote: > > On Wed, Feb 17, 2016 at 04:11:44PM +0100, Marek Polacek wrote: > > > On Wed, Feb 17, 2016 at 06:08:14PM +0300, Ilya Verbin wrote: > > > > > This line is too long. But

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Jakub Jelinek
On Wed, Feb 17, 2016 at 04:11:44PM +0100, Marek Polacek wrote: > On Wed, Feb 17, 2016 at 06:08:14PM +0300, Ilya Verbin wrote: > > > This line is too long. But you could have just done > > > > My editor shows exactly 80 chars. > > The maximum is 79. Well, check_GNU_style.sh complains just about

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Marek Polacek
On Wed, Feb 17, 2016 at 06:08:14PM +0300, Ilya Verbin wrote: > > This line is too long. But you could have just done > > My editor shows exactly 80 chars. The maximum is 79. Marek

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Ilya Verbin
On Wed, Feb 17, 2016 at 15:46:00 +0100, Jakub Jelinek wrote: > On Wed, Feb 17, 2016 at 05:32:58PM +0300, Ilya Verbin wrote: > > + && !SCALAR_FLOAT_TYPE_P (TREE_TYPE (t)) > > + && TREE_CODE (TREE_TYPE (t)) != POINTER_TYPE) > > + { > > + error_at

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Jakub Jelinek
On Wed, Feb 17, 2016 at 05:32:58PM +0300, Ilya Verbin wrote: > This patch fixes > Bootstrap and make check passed. OK for... stage 1? Ok for stage1, with a few nits. > --- a/gcc/c/c-typeck.c > +++ b/gcc/c/c-typeck.c > @@ -12527,7 +12527,8 @@