Re: [PATCH] [AArch64] Fix PR78382

2016-12-07 Thread James Greenhalgh
On Wed, Dec 07, 2016 at 07:25:29AM +, Hurugalawadi, Naveen wrote: > Hi James, > > Thanks for the review and suggestions regarding the testcase. > > >> Why limit the ABI and endianness here > > Extra options have been dropped and the testcase will check across > all variants and endianness.

Re: [PATCH] [AArch64] Fix PR78382

2016-12-06 Thread Hurugalawadi, Naveen
Hi James, Thanks for the review and suggestions regarding the testcase. >> Why limit the ABI and endianness here Extra options have been dropped and the testcase will check across all variants and endianness. Please find attached the modified patch as per the comments and let me know if its

Re: [PATCH] [AArch64] Fix PR78382

2016-11-20 Thread Hurugalawadi, Naveen
Hi Kugan, >> Why don't you use the mode of dest as done in other similar places. Like: Thanks for the pointer. Modified the patch as per your suggestion. Please find attached the modified patch and let me know your comments. Bootstrapped and regression tested on Thunderx. Thanks, Naveen

Re: [PATCH] [AArch64] Fix PR78382

2016-11-18 Thread kugan
Hi Naveen, On 18/11/16 16:30, Hurugalawadi, Naveen wrote: @@ -1374,10 +1374,17 @@ aarch64_load_symref_appropriately (rtx dest, rtx imm, case SYMBOL_SMALL_TLSGD: { rtx_insn *insns; - rtx result = gen_rtx_REG (Pmode, R0_REGNUM); + rtx result; + if

Re: [PATCH] [AArch64] Fix PR78382

2016-11-18 Thread Hurugalawadi, Naveen
Hi Kyrill, Thanks for the comment. Bootstrapped successfully on AArch64 (thunder) system. And also regression tested on AArch64(thunder) with no regressions. Thanks, Naveen

Re: [PATCH] [AArch64] Fix PR78382

2016-11-18 Thread Kyrill Tkachov
Hi Naveen, On 18/11/16 05:30, Hurugalawadi, Naveen wrote: Hi, Please find attached the patch that fixes PR78382. The "SYMBOL_SMALL_TLSGD" was not handled for ILP32. Hence it generates error when compiled for ILP32. The attached patch adds the support and handles it properly as expected for