Re: [PATCH] Fix ICE with vector types in X % -Y pattern (PR middle-end/70050)

2016-03-09 Thread Jakub Jelinek
On Tue, Mar 08, 2016 at 11:16:28PM +0100, Andreas Schwab wrote: > Marek Polacek writes: > > > diff --git gcc/testsuite/gcc.dg/pr70050.c gcc/testsuite/gcc.dg/pr70050.c > > index e69de29..610456f 100644 > > --- gcc/testsuite/gcc.dg/pr70050.c > > +++

Re: [PATCH] Fix ICE with vector types in X % -Y pattern (PR middle-end/70050)

2016-03-08 Thread Andreas Schwab
Marek Polacek writes: > diff --git gcc/testsuite/gcc.dg/pr70050.c gcc/testsuite/gcc.dg/pr70050.c > index e69de29..610456f 100644 > --- gcc/testsuite/gcc.dg/pr70050.c > +++ gcc/testsuite/gcc.dg/pr70050.c > @@ -0,0 +1,11 @@ > +/* PR middle-end/70025 */ > +/* { dg-do compile }

Re: [PATCH] Fix ICE with vector types in X % -Y pattern (PR middle-end/70050)

2016-03-03 Thread Jakub Jelinek
On Thu, Mar 03, 2016 at 01:56:05PM +0100, Marc Glisse wrote: > On Thu, 3 Mar 2016, Marek Polacek wrote: > > >We crashed on the attached testcase because we were trying to apply the > >X % -Y -> X % Y transformation even on vectors. That doesn't go well with > >the > >check for !TYPE_UNSIGNED.

Re: [PATCH] Fix ICE with vector types in X % -Y pattern (PR middle-end/70050)

2016-03-03 Thread Marek Polacek
On Thu, Mar 03, 2016 at 01:56:05PM +0100, Marc Glisse wrote: > On Thu, 3 Mar 2016, Marek Polacek wrote: > > >We crashed on the attached testcase because we were trying to apply the > >X % -Y -> X % Y transformation even on vectors. That doesn't go well with > >the > >check for !TYPE_UNSIGNED.

Re: [PATCH] Fix ICE with vector types in X % -Y pattern (PR middle-end/70050)

2016-03-03 Thread Marc Glisse
On Thu, 3 Mar 2016, Marek Polacek wrote: We crashed on the attached testcase because we were trying to apply the X % -Y -> X % Y transformation even on vectors. That doesn't go well with the check for !TYPE_UNSIGNED. So I think let's limit the pattern to only work on integral types. I

Re: [PATCH] Fix ICE with vector types in X % -Y pattern (PR middle-end/70050)

2016-03-03 Thread Jakub Jelinek
On Thu, Mar 03, 2016 at 12:04:31PM +0100, Marek Polacek wrote: > We crashed on the attached testcase because we were trying to apply the > X % -Y -> X % Y transformation even on vectors. That doesn't go well with the > check for !TYPE_UNSIGNED. So I think let's limit the pattern to only work on