Re: [PATCH] Fix gcc.target/s390/target-attribute/tattr-2.c testcase

On 01/18/2017 01:05 PM, Jakub Jelinek wrote: ... > Two more things: > 1) > 823 error ("Builtin %qF is not supported without -mhtm " > 824"(default with -march=zEC12 and higher).", fndecl); >is a bug, diagnostics (I think Fortran FE is a big exception here)

Re: [PATCH] Fix gcc.target/s390/target-attribute/tattr-2.c testcase

Hi! On Wed, Jan 18, 2017 at 12:49:19PM +0100, Dominik Vogt wrote: > > I think the testcase as written just assumes ICF happens but in a certain > > way and what broke is that the same functions are ICFed in a different order > > now, because with -fno-ipa-icf it reports: > > tattr-2.c: In function

Re: [PATCH] Fix gcc.target/s390/target-attribute/tattr-2.c testcase

On Wed, Jan 18, 2017 at 11:21:50AM +0100, Jakub Jelinek wrote: > On Wed, Jan 18, 2017 at 10:53:59AM +0100, Martin Liška wrote: > > As I've been reading when the warning is emitted (rtl expansion), I guess a > > pair of function was merged > > by IPA ICF and thus the location points to a different

Re: [PATCH] Fix gcc.target/s390/target-attribute/tattr-2.c testcase

On 01/18/2017 11:21 AM, Jakub Jelinek wrote: > 2017-01-18 Jakub Jelinek > > * gcc.target/s390/target-attribute/tattr-2.c: Add -fno-ipa-icf > to dg-options. > (p0): Add missing dg-error. Ok. Thanks! -Andreas-

Re: [PATCH] Fix gcc.target/s390/target-attribute/tattr-2.c testcase

On 01/18/2017 11:21 AM, Jakub Jelinek wrote: > So my preference is to add -fno-ipa-icf to dg-options and > add the missing dg-error line on line 42. > > Like below, ok for trunk? I like the idea of adding -fno-ipa-icf to the test-case. Martin