Re: [PATCH] Fortran : ICE in build_field PR95614 (2nd attempt)

2020-10-13 Thread Paul Richard Thomas via Gcc-patches
Hi Mark, OK for master. If you want to backport, that's fine by me but please give it a few weeks. Thanks for fixing this. Paul On Tue, 13 Oct 2020 at 08:17, Mark Eggleston wrote: > **ping** > > previously omitted commit message added > > On 29/09/2020 14:03, Mark Eggleston wrote: > > For

Re: [PATCH] Fortran : ICE in build_field PR95614 (2nd attempt)

2020-10-13 Thread Mark Eggleston
**ping** previously omitted commit message added On 29/09/2020 14:03, Mark Eggleston wrote: For review. When the first attempt was committed the result was PR97224 i.e. it broke the build of SPECCPU 2006 Games. I've changed the condition under which the error is produced. It was produced

Re: *PING* Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-24 Thread Thomas König
Hi Mark, I haven't yet committed this. I am unfamiliar with Andre, I've checked MAINTAINERS and I find Andre in the "Write after approval" section. Is Andre's approval sufficient? If so MAINTAINERS needs to be updated. The official list of people who can review is at

*PING* Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-24 Thread Mark Eggleston
I haven't yet committed this. I am unfamiliar with Andre, I've checked MAINTAINERS and I find Andre in the "Write after approval" section. Is Andre's approval sufficient? If so MAINTAINERS needs to be updated. If not: OK to commit and backport? regards, Mark On 14/09/2020 09:03, Andre

Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-14 Thread Andre Vehreschild
Hi Marc, the patch looks reasonable and ok to me. Ok for trunk. Thanks for the patch. Regards, Andre On Fri, 4 Sep 2020 08:35:59 +0100 Mark Eggleston wrote: > Please find attached a fix for PR95614.  The original patch was by Steve > Kargl. > > The original patch resulted in name

Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-14 Thread Mark Eggleston
**ping** On 04/09/2020 08:35, Mark Eggleston wrote: Please find attached a fix for PR95614.  The original patch was by Steve Kargl. The original patch resulted in name clashes between global identifiers naming common blocks and local identifiers.  According to the 2018 standard 19.3.1