Re: [PATCH] IPA: do not release body if still needed

2023-01-19 Thread Martin Jambor
Hi, On Wed, Jan 18 2023, Jan Hubicka wrote: >> The code removing function bodies when the last call graph clone of a >> node is removed is too aggressive when there are nodes up the >> clone_of chain which still need them. Fixed by expanding the check. >> >> gcc/ChangeLog: >> >> 2023-01-18

Re: [PATCH] IPA: do not release body if still needed

2023-01-18 Thread Jan Hubicka via Gcc-patches
> The code removing function bodies when the last call graph clone of a > node is removed is too aggressive when there are nodes up the > clone_of chain which still need them. Fixed by expanding the check. > > gcc/ChangeLog: > > 2023-01-18 Martin Jambor > > PR ipa/107944 > *

Re: [PATCH] IPA: do not release body if still needed

2023-01-18 Thread Martin Jambor
Hi, On Mon, Jan 16 2023, Martin Liška wrote: > On 1/14/23 22:36, Jan Hubicka wrote: >>> Noticed during building of libbackend.a with the LTO partial linking. >>> >>> The function release_body is called even if clone_of is a clone >>> of a another function and thus it shares tree declaration. We

Re: [PATCH] IPA: do not release body if still needed

2023-01-16 Thread Martin Liška
On 1/14/23 22:36, Jan Hubicka wrote: >> Hi. >> >> Noticed during building of libbackend.a with the LTO partial linking. >> >> The function release_body is called even if clone_of is a clone >> of a another function and thus it shares tree declaration. We should >> preserve it in that situation. >>

Re: [PATCH] IPA: do not release body if still needed

2023-01-14 Thread Jan Hubicka via Gcc-patches
> Hi. > > Noticed during building of libbackend.a with the LTO partial linking. > > The function release_body is called even if clone_of is a clone > of a another function and thus it shares tree declaration. We should > preserve it in that situation. > > Patch can bootstrap on x86_64-linux-gnu

Re: [PATCH] IPA: do not release body if still needed

2023-01-13 Thread Martin Jambor
Hi, sorry for getting to this so late. On Thu, Dec 01 2022, Martin Liška wrote: > Hi. > > Noticed during building of libbackend.a with the LTO partial linking. The testcase is areally nice one, too bad it's probably impossible to get it small enough to be included in the testcase. But it also

Re: [PATCH] IPA: do not release body if still needed

2022-12-28 Thread Martin Liška
PING^2 On 12/9/22 09:28, Martin Liška wrote: > PING^1 > > On 12/1/22 10:59, Martin Liška wrote: >> Hi. >> >> Noticed during building of libbackend.a with the LTO partial linking. >> >> The function release_body is called even if clone_of is a clone >> of a another function and thus it shares

Re: [PATCH] IPA: do not release body if still needed

2022-12-09 Thread Martin Liška
PING^1 On 12/1/22 10:59, Martin Liška wrote: > Hi. > > Noticed during building of libbackend.a with the LTO partial linking. > > The function release_body is called even if clone_of is a clone > of a another function and thus it shares tree declaration. We should > preserve it in that