Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2017-12-19 Thread Arnaud Charlet
Simon, Unfortunately we've discovered that your patch is causing unexpected consequences and break e.g. testing of ravenscar application, where although the Ada RM requires no task termination, for practical purposes, waiting for terminating task is something we rely upon for automatic testing,

Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2017-12-05 Thread Arnaud Charlet
> I've come up with a considerably simpler patch, which merely causes the > procedure adafinal to be generated with a null body if the restriction > No_Task_Termination is set (note, this restriction is part of the > Ravenscar profile; if tasks can't terminate, program level finalization > can't

Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2017-12-05 Thread Simon Wright
On 7 Mar 2017, at 16:20, Simon Wright wrote: > > On 19 Dec 2015, at 22:05, Simon Wright wrote: >> >> On 12 Nov 2015, at 10:02, Arnaud Charlet wrote: >>> > This situation arises, for example, with an embedded RTS that >

Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2017-03-07 Thread Simon Wright
On 19 Dec 2015, at 22:05, Simon Wright wrote: > > On 12 Nov 2015, at 10:02, Arnaud Charlet wrote: >> This situation arises, for example, with an embedded RTS that incorporates the Ada 2012 generalized container iterators. >>> >>> I

Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2015-12-19 Thread Simon Wright
On 12 Nov 2015, at 10:02, Arnaud Charlet wrote: > >>> This situation arises, for example, with an embedded RTS that >>> incorporates the >>> Ada 2012 generalized container iterators. >> >> I should add, this PR is the ???other half??? of PR ada/66242, which is fixed >> in

Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2015-11-12 Thread Simon Wright
On 11 Nov 2015, at 19:43, Simon Wright wrote: > This situation arises, for example, with an embedded RTS that incorporates the > Ada 2012 generalized container iterators. I should add, this PR is the “other half” of PR ada/66242, which is fixed in GCC 6; so please can it

Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2015-11-12 Thread Arnaud Charlet
> > This situation arises, for example, with an embedded RTS that > > incorporates the > > Ada 2012 generalized container iterators. > > I should add, this PR is the ???other half??? of PR ada/66242, which is fixed > in GCC 6; so please can it be reviewed? The proper patch for PR ada/66242

Re: [PATCH] PR ada/66205 gnatbind generates invalid code when finalization is enabled in restricted runtime

2015-11-11 Thread Simon Wright
I’ve updated the original patch, which was built against 5.1.0 on x64_64-apple-darwin13, this patch is against 6.0.0-20151101 on x86_64-apple-darwin15. -- If the RTS in use is "configurable" (I believe this is the same in this context as "restricted") and includes finalization,