Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-17 Thread Robin Dapp
> So, going back to our testcases that reported errors with this, I > don't think we should explicitly specify -march and -mabi when > compiling a runnable program, but use the defaults (--with-arch). > Most of our current runnable testcases adhere to this convention, > except for the ones we

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-17 Thread Lehua Ding
CC: juzhe.zh...@rivai.ai; gcc-patches; palmer; jeffreyalaw Subject: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs. Hi Kito, On 2023/11/13 19:13, Lehua Ding wrote: Hi Robin, On 2023/11/13 18:33, Robin Dapp wrote: On 2023/11/13 18:22, juzhe.zh...@rivai.ai wrote: If there is a difference between

Re: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-17 Thread Kito Cheng
to.cheng; Robin Dapp > CC: juzhe.zh...@rivai.ai; gcc-patches; palmer; jeffreyalaw > Subject: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs. > Hi Kito, > > On 2023/11/13 19:13, Lehua Ding wrote: > > Hi Robin, > > > > On 2023/11/13 18:33, Robin Dapp wrote: &

Re: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-15 Thread 钟居哲
multilib patch as Lehua said: https://github.com/gcc-mirror/gcc/commit/17d683d juzhe.zh...@rivai.ai From: Lehua Ding Date: 2023-11-13 19:27 To: kito.cheng; Robin Dapp CC: juzhe.zh...@rivai.ai; gcc-patches; palmer; jeffreyalaw Subject: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs. Hi Kito

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Lehua Ding
Hi Kito, On 2023/11/13 19:13, Lehua Ding wrote: Hi Robin, On 2023/11/13 18:33, Robin Dapp wrote: On 2023/11/13 18:22, juzhe.zh...@rivai.ai wrote: If there is a difference between them. I think we should fix riscv-common.cc. Since I think "zvfh_zfh" should not be different with "zfh_zvfh"

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Lehua Ding
Hi Robin, On 2023/11/13 18:33, Robin Dapp wrote: On 2023/11/13 18:22, juzhe.zh...@rivai.ai wrote: If there is a difference between them. I think we should fix riscv-common.cc. Since I think "zvfh_zfh" should not be different with "zfh_zvfh" It's possible. Let me debug it and see if there's a

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Lehua Ding
On 2023/11/13 18:33, Robin Dapp wrote: On 2023/11/13 18:22, juzhe.zh...@rivai.ai wrote: If there is a difference between them. I think we should fix riscv-common.cc. Since I think "zvfh_zfh" should not be different with "zfh_zvfh" It's possible. Let me debug it and see if there's a

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Robin Dapp
> On 2023/11/13 18:22, juzhe.zh...@rivai.ai wrote: >> If there is a difference between them. I think we should fix riscv-common.cc. >> Since I think "zvfh_zfh" should not be different with "zfh_zvfh" > > It's possible. Let me debug it and see if there's a problem. I don't think it is different.

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Lehua Ding
On 2023/11/13 18:22, juzhe.zh...@rivai.ai wrote: If there is a difference between them. I think we should fix riscv-common.cc. Since I think "zvfh_zfh" should not be different with "zfh_zvfh" It's possible. Let me debug it and see if there's a problem. -- Best, Lehua (RiVAI)

Re: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread juzhe.zh...@rivai.ai
eng; jeffreyalaw CC: rdapp.gcc Subject: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs. > Looks like your configure is --with-march=rv32gcv_zvfh, can you change to > --with-march=rv32gcv_zvfh_zfh? From config.log: $ ../configure --prefix=/home/rdapp/projects/builds/gcc --target

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Robin Dapp
> Looks like your configure is --with-march=rv32gcv_zvfh, can you change to > --with-march=rv32gcv_zvfh_zfh? >From config.log: $ ../configure --prefix=/home/rdapp/projects/builds/gcc --target=riscv32-unknown-linux-gnu --disable-nls --disable-multilib --disable-bootstrap

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Lehua Ding
On 2023/11/13 17:59, Robin Dapp wrote: Hi Lehua, Executing on host: /work/home/lding/open-source/riscv-gnu-toolchain-push/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/build-gcc-newlib-stage2/gcc/xgcc

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Robin Dapp
Hi Lehua, > Executing on host: > /work/home/lding/open-source/riscv-gnu-toolchain-push/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/build-gcc-newlib-stage2/gcc/xgcc > >

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Lehua Ding
Hi Robin, Can you show me the compile command in gcc.log for the slp-mask-run-1.exe like bellow? I'd like to see the -march option on your side. Executing on host:

Re: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread juzhe.zh...@rivai.ai
Ok. Lehua is going to take care of this issue. He has reproduced it. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-11-13 17:31 To: juzhe.zh...@rivai.ai; gcc-patches; palmer; kito.cheng; jeffreyalaw CC: rdapp.gcc Subject: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs. > I'm go

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Robin Dapp
> I'm going to configure with --with-arch=rv32gcv_zfh_zvfh --with-abi=ilp32d > to see if there is any difference. No change for me, how do you invoke the testsuite? I.e. Which target board? Regards Robin

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Robin Dapp
> xgcc: fatal error: Cannot find suitable multilib set for > '-march=rv32imafdcv_zicsr_zifencei_zfh_zfhmin_zve32f_zve32x_zve64d_zve64f_zve64x_zvl128b_zvl32b_zvl64b'/'-mabi=ilp32d'^M > compilation terminated.^M > compiler exited with status 1 > FAIL: gcc.target/riscv/rvv/autovec/vmv-imm-run.c -O3

Re: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread juzhe.zh...@rivai.ai
Also, I didn't enable multi-lib. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-11-13 16:52 To: 钟居哲; gcc-patches; palmer; kito.cheng; Jeff Law CC: rdapp.gcc Subject: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs. > FAIL: gcc.target/riscv/rvv/autovec/slp-mask-run-1.c -O3 -ftree-vector

Re: Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread juzhe.zh...@rivai.ai
: testsuite: Fix 32-bit FAILs. > FAIL: gcc.target/riscv/rvv/autovec/slp-mask-run-1.c -O3 -ftree-vectorize > (test for excess errors) > FAIL: gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c -std=c99 -O3 > -ftree-vectorize --param riscv-autovec-preference=fixed-vlmax (test for >

Re: [PATCH] RISC-V: testsuite: Fix 32-bit FAILs.

2023-11-13 Thread Robin Dapp
> FAIL: gcc.target/riscv/rvv/autovec/slp-mask-run-1.c -O3 -ftree-vectorize > (test for excess errors) > FAIL: gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c -std=c99 -O3 > -ftree-vectorize --param riscv-autovec-preference=fixed-vlmax (test for > excess errors) > FAIL: