Re: [PATCH] Use the middle-end boolean_type_node

2017-01-04 Thread Janne Blomqvist
On Tue, Jan 3, 2017 at 9:20 PM, FX wrote: >> The regression with 8 bit boolean types surfaced with the z10 machine. The >> ABI is much older. Since >> we cannot change it anymore we should rather talk to the hardware guys to >> add the instruction we >> need. So for now we

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread Jakub Jelinek
On Tue, Jan 03, 2017 at 09:40:02PM +0200, Janne Blomqvist wrote: > I do think this is fixable without waiting for potential improved > hardware. The vast majority of uses of boolean_type_node in the > Fortran frontend is code like > > tmp = fold_build2_loc (input_location, GT_EXPR, >

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread Janne Blomqvist
On Tue, Jan 3, 2017 at 6:50 PM, Andreas Krebbel wrote: > The regression with 8 bit boolean types surfaced with the z10 machine. The > ABI is much older. Since > we cannot change it anymore we should rather talk to the hardware guys to add > the instruction we > need.

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread FX
> The regression with 8 bit boolean types surfaced with the z10 machine. The > ABI is much older. Since > we cannot change it anymore we should rather talk to the hardware guys to add > the instruction we > need. So for now we probably have to live with the regression in the Fortran > cases

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread FX
> The gfc_init_types change is an ABI change, at least if the fortran FE > bool type is ever stored in memory and accessed by multiple TUs, or > passed as argument etc. And the difference between the C/C++ _Bool/bool > and fortran FE bool has caused lots of issues in the past, so if it can be >

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread Andreas Krebbel
On 01/03/2017 03:31 PM, Janne Blomqvist wrote: > On Tue, Jan 3, 2017 at 4:20 PM, Jakub Jelinek wrote: >> On Tue, Jan 03, 2017 at 03:14:46PM +0100, Dominik Vogt wrote: >>> This patch costs several thousand additional instructions in >>> Spec2006 on s390x ("lines" = instructions):

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread Janne Blomqvist
On Tue, Jan 3, 2017 at 4:20 PM, Jakub Jelinek wrote: > On Tue, Jan 03, 2017 at 03:14:46PM +0100, Dominik Vogt wrote: >> This patch costs several thousand additional instructions in >> Spec2006 on s390x ("lines" = instructions): >> >> 410.bwaves: +28 lines (2 funcs bigger)

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread Jakub Jelinek
On Tue, Jan 03, 2017 at 03:14:46PM +0100, Dominik Vogt wrote: > This patch costs several thousand additional instructions in > Spec2006 on s390x ("lines" = instructions): > > 410.bwaves: +28 lines (2 funcs bigger) > 437.leslie3d: +43 lines (5 funcs bigger) > 434.zeusmp: +2650 lines

Re: [PATCH] Use the middle-end boolean_type_node

2017-01-03 Thread Dominik Vogt
On Tue, Dec 13, 2016 at 10:59:09PM +0200, Janne Blomqvist wrote: > Use the boolean_type_node setup by the middle-end instead of > redefining it. boolean_type_node is not used in GFortran for any > ABI-visible stuff, only internally as the type of boolean > expressions. There appears to be one

Re: [PATCH] Use the middle-end boolean_type_node

2016-12-20 Thread Steve Kargl
Thought I gave an 'ok', but apparently never sent email. Sorry about that. Yes, ok to commit. -- steve On Tue, Dec 20, 2016 at 04:56:51PM +0200, Janne Blomqvist wrote: > PING! > > On Tue, Dec 13, 2016 at 10:59 PM, Janne Blomqvist > wrote: > > Use the

Re: [PATCH] Use the middle-end boolean_type_node

2016-12-20 Thread Janne Blomqvist
PING! On Tue, Dec 13, 2016 at 10:59 PM, Janne Blomqvist wrote: > Use the boolean_type_node setup by the middle-end instead of > redefining it. boolean_type_node is not used in GFortran for any > ABI-visible stuff, only internally as the type of boolean > expressions.