Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-07-14 Thread David Malcolm via Gcc-patches
On Mon, 2020-07-13 at 17:07 -0400, Lewis Hyatt wrote: > On Mon, Jul 13, 2020 at 03:04:20PM -0400, David Malcolm wrote: [...] > > OK for trunk with those nits fixed. > > > > Dave > > > > > > Thanks again for your time! I will address the above and then push in > a day or two. Excellent -

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-07-13 Thread Lewis Hyatt via Gcc-patches
On Mon, Jul 13, 2020 at 03:04:20PM -0400, David Malcolm wrote: > > +@item -fdiagnostics-column-unit=@var{UNIT} > > +@opindex fdiagnostics-column-unit > > +Select the units for the column number. This affects traditional > > diagnostics > > +(in the absence of @option{-fno-show-column}), as well

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-07-13 Thread David Malcolm via Gcc-patches
> On Wed, Jun 10, 2020 at 12:11:00PM -0400, David Malcolm wrote: > > Thanks for the patch; sorry about the delay in reviewing it. > > > > Some high-level review points > > > > - I like the patch overall > > > > - This will deserve an item in the release notes > > > > - I don't like adding

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-06-11 Thread Lewis Hyatt via Gcc-patches
On Wed, Jun 10, 2020 at 12:11:00PM -0400, David Malcolm wrote: > Thanks for the patch; sorry about the delay in reviewing it. > > Some high-level review points > > - I like the patch overall > > - This will deserve an item in the release notes > > - I don't like adding "global_tabstop" (I

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-06-10 Thread David Malcolm via Gcc-patches
On Fri, 2020-05-08 at 15:35 -0400, Lewis Hyatt wrote: > On Fri, Jan 31, 2020 at 03:31:59PM -0500, David Malcolm wrote: > > On Fri, 2020-01-31 at 14:31 -0500, Lewis Hyatt wrote: > > > Hello- > > > > > > Here is the second patch that I mentioned when I submitted the > > > other > > > related > > >

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-05-08 Thread Lewis Hyatt via Gcc-patches
On Fri, Jan 31, 2020 at 03:31:59PM -0500, David Malcolm wrote: > On Fri, 2020-01-31 at 14:31 -0500, Lewis Hyatt wrote: > > Hello- > > > > Here is the second patch that I mentioned when I submitted the other > > related > > patch (which is awaiting review): > >

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-01-31 Thread Lewis Hyatt
Thanks for taking a look, sorry about that, it's my first new option :). I will add in the next iteration. -Lewis On Fri, Jan 31, 2020 at 5:45 PM Joseph Myers wrote: > > This seems to be missing invoke.texi documentation for the new options. > > -- > Joseph S. Myers > jos...@codesourcery.com

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-01-31 Thread Joseph Myers
This seems to be missing invoke.texi documentation for the new options. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-01-31 Thread Lewis Hyatt
On Fri, Jan 31, 2020 at 3:32 PM David Malcolm wrote: > > On Fri, 2020-01-31 at 14:31 -0500, Lewis Hyatt wrote: > > Hello- > > > > Here is the second patch that I mentioned when I submitted the other > > related > > patch (which is awaiting review): > >

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-01-31 Thread David Malcolm
On Fri, 2020-01-31 at 14:31 -0500, Lewis Hyatt wrote: > Hello- > > Here is the second patch that I mentioned when I submitted the other > related > patch (which is awaiting review): > https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01626.html. Sorry about that; I'm v. busy with analyzer bugs