Re: [PATCH] libstdc++: Refactor implementation of operator+ for std::string

2022-11-08 Thread Jonathan Wakely via Gcc-patches
On Thu, 20 Oct 2022 at 01:06, Will Hawkins wrote: > > Sorry for the delay. Tested on x86-64 Linux. > > -->8-- > > After consultation with Jonathan, it seemed like a good idea to create a > single function that performed one-allocation string concatenation that > could be used by various different

Re: [PATCH] libstdc++: Refactor implementation of operator+ for std::string

2022-11-02 Thread Will Hawkins
Just wanted to see if there was anything else I can do to help move this over the finish line! Thanks for all the work that you all do! Sincerely, Will On Wed, Oct 19, 2022 at 8:06 PM Will Hawkins wrote: > > Sorry for the delay. Tested on x86-64 Linux. > > -->8-- > > After consultation with

Re: [PATCH] libstdc++: Refactor implementation of operator+ for std::string

2022-09-09 Thread Jonathan Wakely via Gcc-patches
On Thu, 8 Sept 2022 at 18:51, François Dumont via Libstdc++ wrote: > > On 05/09/22 20:30, Will Hawkins wrote: > > Based on Jonathan's work, here is a patch for the implementation of > > operator+ > > on std::string that makes sure we always use the best allocation strategy. > > > > I have

Re: [PATCH] libstdc++: Refactor implementation of operator+ for std::string

2022-09-09 Thread Will Hawkins
On Thu, Sep 8, 2022 at 2:05 PM Jonathan Wakely wrote: > > > > On Thu, 8 Sep 2022, 18:51 François Dumont via Libstdc++, > wrote: >> >> On 05/09/22 20:30, Will Hawkins wrote: >> > Based on Jonathan's work, here is a patch for the implementation of >> > operator+ >> > on std::string that makes

Re: [PATCH] libstdc++: Refactor implementation of operator+ for std::string

2022-09-08 Thread Jonathan Wakely via Gcc-patches
On Thu, 8 Sep 2022, 18:51 François Dumont via Libstdc++, < libstd...@gcc.gnu.org> wrote: > On 05/09/22 20:30, Will Hawkins wrote: > > Based on Jonathan's work, here is a patch for the implementation of > operator+ > > on std::string that makes sure we always use the best allocation > strategy. >

Re: [PATCH] libstdc++: Refactor implementation of operator+ for std::string

2022-09-08 Thread François Dumont via Gcc-patches
On 05/09/22 20:30, Will Hawkins wrote: Based on Jonathan's work, here is a patch for the implementation of operator+ on std::string that makes sure we always use the best allocation strategy. I have attempted to learn from all the feedback that I got on a previous submission -- I hope I did the