Re: [PATCH] minor FDO profile related fixes

2018-11-30 Thread Jeff Law
On 11/9/18 7:12 PM, Indu Bhagat wrote: > Changelog entry attached. Sorry about that. > > Comments inline. > > Thanks > > On 11/09/2018 04:23 PM, Jeff Law wrote: >> On 11/7/18 5:49 PM, Indu Bhagat wrote: >>> diff --git a/gcc/coverage.c b/gcc/coverage.c >>> index 599a3bb..7595e6c 100644 >>> --- 

Re: [PATCH] minor FDO profile related fixes

2018-11-16 Thread Martin Liška
On 11/16/18 7:08 AM, Indu Bhagat wrote: > > On 11/12/2018 01:48 AM, Martin Liška wrote: >>> make check-gcc on x86_64 shows no new failures. >>> >>> (A related PR washttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=86957  where >>> we added diagnostics for the NO PROFILE case.) >> Hi. >> >> Thanks

Re: [PATCH] minor FDO profile related fixes

2018-11-15 Thread Indu Bhagat
On 11/12/2018 01:48 AM, Martin Liška wrote: make check-gcc on x86_64 shows no new failures. (A related PR washttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=86957 where we added diagnostics for the NO PROFILE case.) Hi. Thanks for the patch. I'm not a maintainer, but the idea of the patch

Re: [PATCH] minor FDO profile related fixes

2018-11-12 Thread Martin Liška
On 11/8/18 1:49 AM, Indu Bhagat wrote: > I have been looking at -fdump-ipa-profile dump with an intention to sanitize > bits of information so that one may use it to judge the "quality of a profile" > in FDO. > > The overall question I want to address is - are there ways to know which > functions 

Re: [PATCH] minor FDO profile related fixes

2018-11-09 Thread Indu Bhagat
Changelog entry attached. Sorry about that. Comments inline. Thanks On 11/09/2018 04:23 PM, Jeff Law wrote: On 11/7/18 5:49 PM, Indu Bhagat wrote: diff --git a/gcc/coverage.c b/gcc/coverage.c index 599a3bb..7595e6c 100644 --- a/gcc/coverage.c +++ b/gcc/coverage.c @@ -358,7 +358,7 @@

Re: [PATCH] minor FDO profile related fixes

2018-11-09 Thread Jeff Law
On 11/7/18 5:49 PM, Indu Bhagat wrote: > I have been looking at -fdump-ipa-profile dump with an intention to sanitize > > bits of information so that one may use it to judge the "quality of a profile" > > in FDO. > > The overall question I want to address is - are there ways to know which >