Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-04 Thread Kito Cheng
both patches are landed, newlib trunk should be able to build with gcc trunk now. On Mon, Dec 4, 2023 at 3:45 PM Kito Cheng wrote: > > RISC-V newlib patch send, one for libgloss and another one for libm, > the libm issue is because we don't have right long double support, > however newlib has

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-03 Thread Kito Cheng
RISC-V newlib patch send, one for libgloss and another one for libm, the libm issue is because we don't have right long double support, however newlib has supported that few months ago, and porting effort is minor, so I just port that to fix the issue :)

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-02 Thread Jeff Law
On 12/1/23 22:47, Sam James wrote: Jeff Law writes: On 12/1/23 18:13, Sam James wrote: 钟居哲 writes: Hi, This patch cause error on building newlib/glibc/musl on RISC-V port:

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Sam James
Jeff Law writes: > On 12/1/23 18:13, Sam James wrote: >> 钟居哲 writes: >> >>> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port: >>> >>>

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Jeff Law
On 12/1/23 18:13, Sam James wrote: 钟居哲 writes: Hi, This patch cause error on building newlib/glibc/musl on RISC-V port: /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: error: passing

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Patrick O'Neill
That failure is is due to newlib files: /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-linux-spike-debug/../../*newlib*/newlib/libm/complex/ccoshl.c: In function 'ccoshl': To build gcc w/ glibc with riscv-gnu-toolchain, run make linux. A temporary fix for

Re: Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread 钟居哲
/build-newlib-nano' make: *** [Makefile:641: stamps/build-newlib-nano] Error 2 Confirm newlib/glibc/musl definitely can not be compiled by trunk GCC. juzhe.zh...@rivai.ai From: Patrick O'Neill Date: 2023-12-02 09:10 To: 钟居哲; gcc-patches CC: thomas; fweimer Subject: Re: [PATCH 2/6] c: Tu

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Sam James
钟居哲 writes: > Hi, This patch cause error on building newlib/glibc/musl on RISC-V port: > > /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: > error: passing argument 3 of 'syscall_errno' makes

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Patrick O'Neill
Hi Juzhe, I can confirm the failure on Newlib. I'm not seeing any issues on glibc 2.37. I haven't tried to build musl. Since this patch promotes warnings to errors breakages were probably expected. The fix may require changes to newlib to remove the errors. I've hacked together a series of

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Florian Weimer
* Thomas Schwinge: > I'm not proposing a patch as I don't know whether you'd like to just > silence the diagnostic, fix (?) the test case, and/or add another > 'dg-error'-checking test case? (I've not yet looked at the history of > the test case.) Jakub just posted a patch: [PATCH]

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Thomas Schwinge
Hi Florian! On 2023-11-13T14:10:34+0100, Florian Weimer wrote: > --- a/gcc/c/c-typeck.cc > +++ b/gcc/c/c-typeck.cc > @@ -7616,27 +7639,28 @@ convert_for_assignment (location_t location, > location_t expr_loc, tree type, > case ic_assign: > - pedwarn (location,

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416]

2023-11-13 Thread Sam James
Florian Weimer writes: > gcc/ > > * doc/invoke.texi (Warning Options): Document changes. > > gcc/c/ > > * c-typeck.cc (build_conditional_expr): Use pedpermerror for > pointer/integer type mismatches, based on -Wint-conversion. > (pedwarn_pedpermerror_init,

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-11-13 Thread Jeff Law
On 11/13/23 06:10, Florian Weimer wrote: gcc/ * doc/invoke.texi (Warning Options): Document changes. gcc/c/ * c-typeck.cc (build_conditional_expr): Use pedpermerror for pointer/integer type mismatches, based on -Wint-conversion. (pedwarn_pedpermerror_init,