Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-22 Thread Richard Biener
On Tue, Sep 22, 2015 at 2:22 AM, Manuel López-Ibáñez wrote: > On 21 September 2015 at 12:29, Richard Biener > wrote: >> On Mon, Sep 21, 2015 at 11:59 AM, Manuel López-Ibáñez >> wrote: >>> On 21 September 2015 at 10:18,

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-21 Thread Richard Biener
On Fri, Sep 18, 2015 at 8:47 PM, Manuel López-Ibáñez wrote: > And now with the patch. > > On 18 September 2015 at 20:40, Manuel López-Ibáñez > wrote: >> In https://sourceware.org/ml/libc-alpha/2014-12/msg00300.html, we give a >> "called from here"

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-21 Thread Manuel López-Ibáñez
On 21 September 2015 at 12:29, Richard Biener wrote: > On Mon, Sep 21, 2015 at 11:59 AM, Manuel López-Ibáñez > wrote: >> On 21 September 2015 at 10:18, Richard Biener >> wrote: >>> input_location is set from the call

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-21 Thread Manuel López-Ibáñez
On 21 September 2015 at 12:29, Richard Biener wrote: >>> least note the function we are failing to inline to (thus, use >>> DECL_SOURCE_LOCATION >>> of cfun->decl). So better add a diag_location and compute that upfront to >>> avoid >>> repeating the check. >> >>

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-21 Thread Richard Biener
On Mon, Sep 21, 2015 at 12:46 PM, Manuel López-Ibáñez wrote: > On 21 September 2015 at 12:29, Richard Biener > wrote: least note the function we are failing to inline to (thus, use DECL_SOURCE_LOCATION of cfun->decl). So better

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-21 Thread Trevor Saunders
On Mon, Sep 21, 2015 at 12:29:36PM +0200, Richard Biener wrote: > On Mon, Sep 21, 2015 at 11:59 AM, Manuel López-Ibáñez > wrote: > > On 21 September 2015 at 10:18, Richard Biener > > wrote: > >> input_location is set from the call stmt: > >> >

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-21 Thread Manuel López-Ibáñez
On 21 September 2015 at 10:18, Richard Biener wrote: > input_location is set from the call stmt: > > /* FIXME: instantiate_decl isn't called by inlinable_function_p. */ > saved_location = input_location; > input_location = gimple_location (stmt); > > it would be

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-21 Thread Richard Biener
On Mon, Sep 21, 2015 at 11:59 AM, Manuel López-Ibáñez wrote: > On 21 September 2015 at 10:18, Richard Biener > wrote: >> input_location is set from the call stmt: >> >> /* FIXME: instantiate_decl isn't called by inlinable_function_p. */ >>

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

2015-09-18 Thread Manuel López-Ibáñez
And now with the patch. On 18 September 2015 at 20:40, Manuel López-Ibáñez wrote: > In https://sourceware.org/ml/libc-alpha/2014-12/msg00300.html, we give a > "called from here" note without actually having a location, which looks > strange. I haven't been able to generate