-原始邮件-
发件人: "Jeff Law"
发送时间: 2023-04-05 09:30:43 (星期三)
收件人: "Hans-Peter Nilsson" , Jiawei
抄送: gcc-patches@gcc.gnu.org, kito.ch...@sifive.com, pal...@dabbelt.com,
christoph.muell...@vrull.eu, wuwei2...@iscas.ac.cn
主题: Re: [PATCH v2] RISC-V: Add Z*inx imcom
On 4/3/23 19:46, Hans-Peter Nilsson wrote:
On Tue, 28 Mar 2023, Jiawei wrote:
+ // Zfinx is conflict with float extensions.
+ if (TARGET_ZFINX && TARGET_HARD_FLOAT)
+error ("z*inx is conflict with float extensions");
+
While I'm not a native English speaker, "is conflict with"
On Tue, 28 Mar 2023, Jiawei wrote:
> + // Zfinx is conflict with float extensions.
> + if (TARGET_ZFINX && TARGET_HARD_FLOAT)
> +error ("z*inx is conflict with float extensions");
> +
While I'm not a native English speaker, "is conflict with"
doesn't sound grammatically correct. Perhaps
Maybe something like this?
diff --git a/gcc/common/config/riscv/riscv-common.cc
b/gcc/common/config/riscv/riscv-common.cc
index acfd7b92563..aa7edc8cfec 100644
--- a/gcc/common/config/riscv/riscv-common.cc
+++ b/gcc/common/config/riscv/riscv-common.cc
@@ -1155,6 +1155,10 @@
Hi Kito,
Thanks for your sugestions, I had added the new testcases in the new patch.
I feel it's hard to check long string name extension by use
riscv_subset_list::parse,
Since it just check one char when the pointer moving, So I still keep the
implement
by check the extenstison with target.
I would prefer those checking happened in
riscv_subset_list::parse@gcc/common/config/riscv/riscv-common.cc that
could be reused when we adding target attribute.
And I plan integrate the arch-canonicalize script to just reusing
whole arch string parser in GCC 14, so it would be great to have all
