Re: [PATCH v3 0/6] RISC-V: Support XTheadVector extension

2023-12-20 Thread Jeff Law
On 12/20/23 20:30, juzhe.zh...@rivai.ai wrote: OK.  Sounds reasonable. But from my side, I used to commit patches after full coverage testing. Understood. And it's appreciated -- the code you're doing hits a wide variety of configurations, so the wider testing is probably applicable.

Re: Re: [PATCH v3 0/6] RISC-V: Support XTheadVector extension

2023-12-20 Thread juzhe.zh...@rivai.ai
: [PATCH v3 0/6] RISC-V: Support XTheadVector extension On 12/20/23 16:08, 钟居哲 wrote: > Btw, rv32/rv64gc or rv32/rv64 gcv testing is not enough. > > We need full coverage testing, since we always commit patch after no > regression testing on full coverage testing: No. It is

Re: [PATCH v3 0/6] RISC-V: Support XTheadVector extension

2023-12-20 Thread Jeff Law
On 12/20/23 16:08, 钟居哲 wrote: Btw, rv32/rv64gc or rv32/rv64 gcv testing is not enough. We need full coverage testing, since we always commit patch after no regression testing on full coverage testing: No. It is unreasonable to require this large of test matrix for the vast majority if

Re: [PATCH v3 0/6] RISC-V: Support XTheadVector extension

2023-12-20 Thread 钟居哲
Btw, rv32/rv64gc or rv32/rv64 gcv testing is not enough. We need full coverage testing, since we always commit patch after no regression testing on full coverage testing: with these following configurations: -march=rv[32/64]gc_zve32f_zvfh_zfh -march=rv[32/64]gc_zve64d_zvfh_zfh

Re: [PATCH v3 0/6] RISC-V: Support XTheadVector extension

2023-12-20 Thread 钟居哲
Hi, Joshua. Thanks for working hard on clean up codes and support tons of work on theadvector. After fully review this patch, I understand you have 3 kinds of theadvector intrinsics from the codebase of current RVV1.0 GCC. 1). instructions that can leverage all current codes of RVV1.0