Re: [Patch]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2021-12-16 Thread Qing Zhao via Gcc-patches
> On Dec 15, 2021, at 11:33 AM, Qing Zhao via Gcc-patches > wrote: > > > >> On Dec 14, 2021, at 4:06 PM, Martin Sebor wrote: >> >> > > Dynamically creating the string seems quite cumbersome here, and > it leaks the allocated block. I wonder if it might be better to

Re: [Patch]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2021-12-15 Thread Qing Zhao via Gcc-patches
> On Dec 14, 2021, at 4:06 PM, Martin Sebor wrote: > > Dynamically creating the string seems quite cumbersome here, and it leaks the allocated block. I wonder if it might be better to remove the gmsgid argument from the function and assign it to one of the

Re: [Patch]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2021-12-14 Thread Martin Sebor via Gcc-patches
On 12/14/21 9:43 AM, Qing Zhao wrote: Hi, On Dec 9, 2021, at 12:13 PM, Qing Zhao via Gcc-patches wrote: + return; + + /* Get the variable declaration location from the def_stmt. */ + var_decl_loc = gimple_location (def_stmt); + + /* The LHS of the call

Re: [Patch]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2021-12-14 Thread Qing Zhao via Gcc-patches
Hi, > On Dec 9, 2021, at 12:13 PM, Qing Zhao via Gcc-patches > wrote: >> >>> + return; >>> + >>> + /* Get the variable declaration location from the def_stmt. */ >>> + var_decl_loc = gimple_location (def_stmt); >>> + >>> + /* The LHS of the call is a temporary variable, we

Re: [Patch]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2021-12-09 Thread Qing Zhao via Gcc-patches
Hi, Martin, Thanks a lot for your review and comments. > On Dec 9, 2021, at 11:43 AM, Martin Sebor wrote: >> >> diff --git a/gcc/tree-ssa-uninit.c b/gcc/tree-ssa-uninit.c >> index 1df0bcc42c0..85d1ba866fc 100644 >> --- a/gcc/tree-ssa-uninit.c >> +++ b/gcc/tree-ssa-uninit.c >> @@ -182,9 +182,22

Re: [Patch]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2021-12-09 Thread Martin Sebor via Gcc-patches
On 12/7/21 8:36 AM, Qing Zhao via Gcc-patches wrote: Hi, This patch is to resolve the following two issues in the current implemenation of -ftrivial-auto-var-init: 1. The 3rd parameter of function .DEFERRED_INIT is IS_VLA currently, which is not needed at all; 2. The address taken variable