Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 11:22 AM, Julian Brown jul...@codesourcery.com wrote: On Mon, 11 Jun 2012 16:46:27 +0100 Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: Hi, I don't like the ML bits of the patch as it stands today and before committing I would like to clean up the ML

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Ramana Radhakrishnan
On 12 June 2012 11:46, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jun 12, 2012 at 11:22 AM, Julian Brown jul...@codesourcery.com wrote: On Mon, 11 Jun 2012 16:46:27 +0100 Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: Hi, I don't like the ML bits of the patch

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Ramana Radhakrishnan
On 12 June 2012 10:22, Julian Brown jul...@codesourcery.com wrote: On Mon, 11 Jun 2012 16:46:27 +0100 Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: Hi, I don't like the ML bits of the patch as it stands today and before committing I would like to clean up the ML bits quite a

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 1:07 PM, Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: On 12 June 2012 11:46, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jun 12, 2012 at 11:22 AM, Julian Brown jul...@codesourcery.com wrote: On Mon, 11 Jun 2012 16:46:27 +0100 Ramana

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 2:12 PM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jun 12, 2012 at 1:07 PM, Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: On 12 June 2012 11:46, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jun 12, 2012 at 11:22 AM, Julian

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Ramana Radhakrishnan
+  if (TREE_CODE (mask) == SSA_NAME) +    { +      gimple def_stmt = SSA_NAME_DEF_STMT (mask); +      if (is_gimple_assign (def_stmt) +         gimple_assign_rhs_code (def_stmt) == VECTOR_CST) +       mask = gimple_assign_rhs1 (def_stmt); +    } +   if (TREE_CODE (mask) == VECTOR_CST)  

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 2:23 PM, Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: +  if (TREE_CODE (mask) == SSA_NAME) +    { +      gimple def_stmt = SSA_NAME_DEF_STMT (mask); +      if (is_gimple_assign (def_stmt) +         gimple_assign_rhs_code (def_stmt) == VECTOR_CST) +    

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-11 Thread Richard Henderson
On 2012-06-11 14:12, Ramana Radhakrishnan wrote: I could generate the masks with appropriate casts to unsigned variants instead.That doesn't seem to make a difference either. No, that shouldn't make any difference. r~