Re: [google] Refine static branch prediction (iv-compare heuristic)

2012-03-28 Thread Xinliang David Li
Can the test case be improved so that expected prediction results is checked (with the help of more dumping such as blah blah is predicted to be taken/not taken with probability xyz) ? Also the more test cases need to be added to cover more cases base, base +1, =base +2, base+1, =base+1 etc --

Re: [google] Refine static branch prediction (iv-compare heuristic)

2012-03-28 Thread Dehao Chen
Thanks, attached is the updated patch. Dehao Index: gcc/testsuite/gcc.dg/predict-3.c === --- gcc/testsuite/gcc.dg/predict-3.c(revision 185903) +++ gcc/testsuite/gcc.dg/predict-3.c(working copy) @@ -10,10 +10,16 @@ int i,

Re: [google] Refine static branch prediction (iv-compare heuristic)

2012-03-28 Thread Xinliang David Li
Ok for google branches. thanks, David On Wed, Mar 28, 2012 at 7:55 PM, Dehao Chen de...@google.com wrote: Thanks, attached is the updated patch. Dehao Index: gcc/testsuite/gcc.dg/predict-3.c === ---