Re: Async I/O patch with compilation fix

2018-08-23 Thread Thomas Koenig
David, I will take the "thank you for restoring bootstrap for AIX" as implied in your e-mail. Second, the patch that you applied is unacceptable.  ASYNC_IO already is set to zero for AIX. There is a clear procedure for this something that you deem "unacceptable": Submit a patch (for which I

Re: Async I/O patch with compilation fix

2018-08-23 Thread David Edelsohn
Thomas, Once the plural.c file has been re-generated incorrectly using the local Yacc, it must be deleted and checked out again. Did you pull it fresh from the repository in your AIX tree after the incorrect checkout? Thanks, David On Wed, Aug 22, 2018 at 5:30 PM Thomas Koenig wrote: > Hi

Re: Async I/O patch with compilation fix

2018-08-23 Thread David Edelsohn
Thomas, After your complaint about bootstrap on gcc119, I tried it again. My bootstrap worked correctly. I used exactly the public instructions. Others have been able to bootstrap on gcc119. The problem is local to you. Does your environment have any special variables? You can see the

Re: Async I/O patch with compilation fix

2018-08-22 Thread Thomas Koenig
Hi David, This patch broke bootstrap on AIX again. This is completely unacceptable. Again, sorry for the breakage. I faced quite some challenges trying to get bootstrap to work on gcc119. Despite quite a few e-mails (plus hints in a PR) that I received, none of the hints for bootstrap I got

Re: Async I/O patch with compilation fix

2018-08-22 Thread David Edelsohn
Thomas, This patch broke bootstrap on AIX again. This is completely unacceptable. In file included from */nasfarm/edelsohn/src/src/libgfortran/runtime/error.c:28*: */nasfarm/edelsohn/src/src/libgfortran/io/async.h:333:3:* *error: *unknown type name '*__gthread_cond_t*' 333 |

Re: Async I/O patch with compilation fix

2018-08-21 Thread Thomas Koenig
Hi everybody, Nicolas has committed the patch as r263750. PR 87048 now traces the armeb regression, which is assumed to resurface now. Let's really try and fix that one before 9.0 :-) Regards Thomas

Re: Async I/O patch with compilation fix

2018-08-19 Thread Thomas Koenig
Hi Christophe, Hi, This is done by +#if defined(__GTHREAD_HAS_COND) && defined(__GTHREADS_CXX0X) && !defined(__ARMEB__) +#define ASYNC_IO 1 +#else +#define ASYNC_IO 0 +#endif I tried this version of the patch, and I'm still seeing the regression on array_constructor_8.f90. Urgh...

Re: Async I/O patch with compilation fix

2018-08-18 Thread Christophe Lyon
On Fri, 17 Aug 2018 at 17:41, Thomas Koenig wrote: > > Hi Christophe, > Hi, > sorry that this took so long, but a holiday followed by a > business trip seven timezones away can do that :-) > Sorry, I am on holidays too, and not back yet :) > > I applied this patch, and again I still see

Re: Async I/O patch with compilation fix

2018-08-17 Thread Thomas Koenig
Hi Christophe, sorry that this took so long, but a holiday followed by a business trip seven timezones away can do that :-) I applied this patch, and again I still see regressions on armeb-none-linux-gnueabihf --with-cpu cortex-a9 --with-fpu neon-fp16 The info that you supplied in the PR

Re: Async I/O patch with compilation fix

2018-08-06 Thread Christophe Lyon
On Sat, 4 Aug 2018 at 00:42, Thomas König wrote: > > Hi Cristophe, > > this is seriously weird - there is not even an I/O statement in that test > case. > > One question: Is this real hardware or an emulator? I'm using QEMU > Also, Could you try a few things? > > Run the test case manually. Do

Re: Async I/O patch with compilation fix

2018-08-03 Thread Thomas König
Hi Cristophe, this is seriously weird - there is not even an I/O statement in that test case. One question: Is this real hardware or an emulator? Also, Could you try a few things? Run the test case manually. Do you still fail? Is there an error if the executable is run under valgrind? If you

Re: Async I/O patch with compilation fix

2018-08-03 Thread Christophe Lyon
On Thu, 2 Aug 2018 at 19:05, Nicolas Koenig wrote: > > On Thu, Aug 02, 2018 at 05:42:46PM +0200, Christophe Lyon wrote: > > On Thu, 2 Aug 2018 at 13:35, Nicolas Koenig > > wrote: > > > > > > > > > Hello everyone, > > > > > > Here is an updated version of the patch that hopefully fixes the > >

Re: Async I/O patch with compilation fix

2018-08-02 Thread Nicolas Koenig
On Thu, Aug 02, 2018 at 05:42:46PM +0200, Christophe Lyon wrote: > On Thu, 2 Aug 2018 at 13:35, Nicolas Koenig wrote: > > > > > > Hello everyone, > > > > Here is an updated version of the patch that hopefully fixes the compilation > > problems by disabling async I/O if conditions are not

Re: Async I/O patch with compilation fix

2018-08-02 Thread Christophe Lyon
On Thu, 2 Aug 2018 at 13:35, Nicolas Koenig wrote: > > > Hello everyone, > > Here is an updated version of the patch that hopefully fixes the compilation > problems by disabling async I/O if conditions are not supported by the target. > > I would appreciate if people could test it on systems on