Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767) (version 2)

2017-01-04 Thread Joseph Myers
On Wed, 4 Jan 2017, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-linux, ok for trunk? The C changes are OK. -- Joseph S. Myers jos...@codesourcery.com

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767) (version 2)

2017-01-04 Thread Jason Merrill
On Wed, Jan 4, 2017 at 1:19 PM, Marek Polacek wrote: > +Note that the code above is illegal in C++11. "invalid". The C++ changes are OK. Jason

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2017-01-03 Thread Eric Gallager
On 10/2/16, Jason Merrill wrote: > OK, thanks. > > On Sat, Oct 1, 2016 at 10:16 AM, Marek Polacek wrote: >> On Fri, Sep 30, 2016 at 05:48:03PM -0400, Jason Merrill wrote: >>> On Fri, Sep 30, 2016 at 12:43 PM, Marek Polacek >>> wrote: >>>

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-10-02 Thread Jason Merrill
OK, thanks. On Sat, Oct 1, 2016 at 10:16 AM, Marek Polacek wrote: > On Fri, Sep 30, 2016 at 05:48:03PM -0400, Jason Merrill wrote: >> On Fri, Sep 30, 2016 at 12:43 PM, Marek Polacek wrote: >> > On Fri, Sep 23, 2016 at 10:31:33AM -0400, Jason Merrill

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-10-01 Thread Marek Polacek
On Fri, Sep 30, 2016 at 05:48:03PM -0400, Jason Merrill wrote: > On Fri, Sep 30, 2016 at 12:43 PM, Marek Polacek wrote: > > On Fri, Sep 23, 2016 at 10:31:33AM -0400, Jason Merrill wrote: > >> On Fri, Sep 23, 2016 at 9:15 AM, Marek Polacek wrote: > >> > On

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-30 Thread Martin Sebor
On 09/30/2016 01:40 PM, Marek Polacek wrote: On Fri, Sep 30, 2016 at 01:08:19PM -0600, Martin Sebor wrote: On 09/30/2016 11:05 AM, Martin Sebor wrote: +permerror (input_location, "ISO C++11 only allows pointer " + "conversions for integer literals"); FWIW, I think it

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-30 Thread Jason Merrill
On Fri, Sep 30, 2016 at 12:43 PM, Marek Polacek wrote: > On Fri, Sep 23, 2016 at 10:31:33AM -0400, Jason Merrill wrote: >> On Fri, Sep 23, 2016 at 9:15 AM, Marek Polacek wrote: >> > On Wed, Sep 21, 2016 at 03:52:09PM -0400, Jason Merrill wrote: >> >> On

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-30 Thread Marek Polacek
On Fri, Sep 30, 2016 at 01:08:19PM -0600, Martin Sebor wrote: > On 09/30/2016 11:05 AM, Martin Sebor wrote: > > > +permerror (input_location, "ISO C++11 only allows pointer " > > > + "conversions for integer literals"); > > > > FWIW, I think it would be clearer to either

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-30 Thread Martin Sebor
On 09/30/2016 11:05 AM, Martin Sebor wrote: +permerror (input_location, "ISO C++11 only allows pointer " + "conversions for integer literals"); FWIW, I think it would be clearer to either mention the currently selected language version or leave it out completely rather

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-30 Thread Martin Sebor
+ permerror (input_location, "ISO C++11 only allows pointer " + "conversions for integer literals"); FWIW, I think it would be clearer to either mention the currently selected language version or leave it out completely rather than hardcoding C++11. When

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-30 Thread Marek Polacek
On Fri, Sep 23, 2016 at 10:31:33AM -0400, Jason Merrill wrote: > On Fri, Sep 23, 2016 at 9:15 AM, Marek Polacek wrote: > > On Wed, Sep 21, 2016 at 03:52:09PM -0400, Jason Merrill wrote: > >> On Mon, Sep 19, 2016 at 2:49 PM, Jason Merrill wrote: > >> > I

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-23 Thread Jason Merrill
On Fri, Sep 23, 2016 at 9:15 AM, Marek Polacek wrote: > On Wed, Sep 21, 2016 at 03:52:09PM -0400, Jason Merrill wrote: >> On Mon, Sep 19, 2016 at 2:49 PM, Jason Merrill wrote: >> > I suppose that an INTEGER_CST of character type is necessarily a >> >

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-23 Thread Marek Polacek
On Wed, Sep 21, 2016 at 03:52:09PM -0400, Jason Merrill wrote: > On Mon, Sep 19, 2016 at 2:49 PM, Jason Merrill wrote: > > I suppose that an INTEGER_CST of character type is necessarily a > > character constant, so adding a check for !char_type_p ought to do the > > trick. > >

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-21 Thread Jason Merrill
On Mon, Sep 19, 2016 at 2:49 PM, Jason Merrill wrote: > I suppose that an INTEGER_CST of character type is necessarily a > character constant, so adding a check for !char_type_p ought to do the > trick. Indeed it does. I'm checking this in: commit

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-19 Thread Jason Merrill
On Thu, Sep 15, 2016 at 8:16 AM, Marek Polacek wrote: > On Wed, Sep 14, 2016 at 12:07:49AM -0400, Jason Merrill wrote: >> On Sat, Sep 10, 2016 at 10:58 AM, Marek Polacek wrote: >> > Spurred by the recent findings, I >> >

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-15 Thread Marek Polacek
On Wed, Sep 14, 2016 at 12:07:49AM -0400, Jason Merrill wrote: > On Sat, Sep 10, 2016 at 10:58 AM, Marek Polacek wrote: > > Spurred by the recent findings, I > > decided to > > implement a warning that warns when a pointer is compared with a

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-13 Thread Jason Merrill
On Sat, Sep 10, 2016 at 10:58 AM, Marek Polacek wrote: > Spurred by the recent findings, I decided > to > implement a warning that warns when a pointer is compared with a zero > character > literal (constant), because this isn't likely to

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-10 Thread Marek Polacek
On Sat, Sep 10, 2016 at 05:07:51PM +0200, Jakub Jelinek wrote: > Hi! > > Just a minor nit: > > On Sat, Sep 10, 2016 at 04:58:43PM +0200, Marek Polacek wrote: > > Spurred by the recent findings, I > > decided to > > implement a warning that warns when a pointer

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-10 Thread Jakub Jelinek
Hi! Just a minor nit: On Sat, Sep 10, 2016 at 04:58:43PM +0200, Marek Polacek wrote: > Spurred by the recent findings, I decided > to > implement a warning that warns when a pointer is compared with a zero > character > literal (constant), because this isn't