Re: Implement -Wimplicit-fallthrough (version 5)

2016-08-24 Thread Martin Sebor
I'm curious why this function takes the first argument by const reference when the function above by const pointer. Is there a subtle difference between the functions that I'm not seeing? For that matter, is there a convention in GCC? (FWIW, my own rule of thumb is to have a function take a

Re: Implement -Wimplicit-fallthrough (version 5)

2016-08-24 Thread Marek Polacek
On Mon, Aug 22, 2016 at 10:31:16AM -0600, Martin Sebor wrote: > Just a few minor nits based on a quick reading of the patch: Thanks for looking into this. > > @@ -24114,6 +24164,16 @@ cp_parser_std_attribute (cp_parser *parser) > > " use %"); > >