Re: [patch,committed] Move gfortran.dg/dec_math_5.f90 to ./ieee/ (was: Re: PATCH -- Fix degree trignometric functions)

2020-04-08 Thread Fritz Reese via Gcc-patches
Andreas, thank you for the report. Tobias, thank you for the fix. --- Fritz Reese On Wed, Apr 8, 2020 at 12:02 PM Tobias Burnus wrote: > > Hi Andreas, > > thanks for the report. In principle, it would be helpful to know on > which target you are running the test case. > > However, I assume

[patch,committed] Move gfortran.dg/dec_math_5.f90 to ./ieee/ (was: Re: PATCH -- Fix degree trignometric functions)

2020-04-08 Thread Tobias Burnus
Hi Andreas, thanks for the report. In principle, it would be helpful to know on which target you are running the test case. However, I assume that either of the following went wrong: * Target does not support IEEE * It supports it, but gfortran's intrinsic search path does not point to

Re: PATCH -- Fix degree trignometric functions

2020-04-08 Thread Andreas Schwab
FAIL: gfortran.dg/dec_math_5.f90 -O0 (test for excess errors) Excess errors: /opt/gcc/gcc-20200408/gcc/testsuite/gfortran.dg/dec_math_5.f90:132:9: Fatal Error: Cannot open module file 'ieee_arithmetic.mod' for reading at (1): No such file or directory compilation terminated. Andreas. --

Re: PATCH -- Fix degree trignometric functions

2020-03-31 Thread Fritz Reese via Gcc-patches
On Fri, Mar 27, 2020 at 7:36 PM Fritz Reese wrote: > > On Fri, Mar 6, 2020 at 6:18 PM Steve Kargl > wrote: > [...] > > TL;DR version. > > > > Fix the simplification and handling of the degree trigonometric functions. > > This includes fixing a number of ICEs. See PR 93871. > > An updated

Re: PATCH -- Fix degree trignometric functions

2020-03-30 Thread Fritz Reese via Gcc-patches
On Mon, Mar 30, 2020 at 4:53 PM Tobias Burnus wrote: > > Hi Fritz, > > On 3/30/20 10:20 PM, Fritz Reese via Fortran wrote: > > >>> * All included files need dependency; I do not quickly > >>>see whether that' the case. > > If one looks at the build, the dependency is automatically > obtained

Re: PATCH -- Fix degree trignometric functions

2020-03-30 Thread Tobias Burnus
Hi Fritz, On 3/30/20 10:20 PM, Fritz Reese via Fortran wrote: * All included files need dependency; I do not quickly see whether that' the case. If one looks at the build, the dependency is automatically obtained and tracked in …/.deps/*.Po in the build directory. Hence, no action needed.

Re: PATCH -- Fix degree trignometric functions

2020-03-30 Thread Fritz Reese via Gcc-patches
On Sat, Mar 28, 2020 at 12:37 PM Steve Kargl wrote: > > On Sat, Mar 28, 2020 at 08:10:38AM +0100, Tobias Burnus wrote: > > Two remarks: > > > > * As the file trigd_lib.inc is shared between libgfortran > > and gcc/fortran, I wonder whether it should be placed > > under include/ (under the GCC

Re: PATCH -- Fix degree trignometric functions

2020-03-28 Thread Steve Kargl via Gcc-patches
On Sat, Mar 28, 2020 at 08:10:38AM +0100, Tobias Burnus wrote: > Two remarks: > > * As the file trigd_lib.inc is shared between libgfortran > and gcc/fortran, I wonder whether it should be placed > under include/ (under the GCC toplevel directroy) The original name and location were chosen

Re: PATCH -- Fix degree trignometric functions

2020-03-28 Thread Tobias Burnus
Two remarks: * As the file trigd_lib.inc is shared between libgfortran and gcc/fortran, I wonder whether it should be placed under include/ (under the GCC toplevel directroy) * All included files need dependency; I do not quickly see whether that' the case. Cheers, Tobias On 3/28/20

Re: PATCH -- Fix degree trignometric functions

2020-03-27 Thread Fritz Reese via Gcc-patches
On Fri, Mar 6, 2020 at 6:18 PM Steve Kargl wrote: [...] > TL;DR version. > > Fix the simplification and handling of the degree trigonometric functions. > This includes fixing a number of ICEs. See PR 93871. An updated version of the patch is attached. Regression tests (and new test cases)

Re: PATCH -- Fix degree trignometric functions

2020-03-09 Thread Fritz Reese
On Sat, Mar 7, 2020 at 1:32 PM Steve Kargl wrote: > > Fix the simplification and handling of the degree trigonometric functions. > This includes fixing a number of ICEs. See PR 93871. > > ChangeLog and patch attached. As the author of the original degree-trig functions I intend to review this

Re: PATCH -- Fix degree trignometric functions

2020-03-07 Thread Steve Kargl
On Fri, Mar 06, 2020 at 03:18:19PM -0800, Steve Kargl wrote: > > 3. Simplification routines do the following mappings: > sind(x) = sin((pi/180) * x) asind(x) = (180/pi) * asin(x) > cosd(x) = cos((pi/180) * x) acosd(x) = (180/pi) * acos(x) > tand(x) = tan((pi/180) * x)