Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-07 Thread H.J. Lu
On Thu, Dec 6, 2018 at 10:04 AM Ian Lance Taylor via gcc-patches wrote: > > On Thu, Dec 6, 2018 at 3:12 AM Nick Clifton wrote: > > > > Is the patch OK with you ? > This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88409 -- H.J.

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-06 Thread Ian Lance Taylor via gcc-patches
On Thu, Dec 6, 2018 at 3:12 AM Nick Clifton wrote: > > Is the patch OK with you ? Yes, thanks. Ian

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-06 Thread Jason Merrill
On 12/4/18 11:56 AM, Nick Clifton wrote: OK, revised (v5) patch attached. Is this version acceptable to all ? Looks good to me. Independently, do you see a reason not to disable the old demangler entirely? Jason

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-06 Thread Nick Clifton
Hi Ian, Is the patch OK with you ? Cheers Nick

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-04 Thread Pedro Alves
On 12/04/2018 04:56 PM, Nick Clifton wrote: > Hi Pedro, > >> The issue pointed out by >> >> https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02592.html >> >> is still present in this version. > > Doh! Yes I meant to fix that one too, but forgot. > >> Also, noticed a typo here: >> >>> +/* If

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-04 Thread Nick Clifton
Hi Pedro, > The issue pointed out by > > https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02592.html > > is still present in this version. Doh! Yes I meant to fix that one too, but forgot. > Also, noticed a typo here: > >> +/* If DMGL_NO_RECURE_LIMIT is not enabled, then this is the value