Re: fix -fmax-errors & notes

2016-10-17 Thread Nathan Sidwell
On 10/14/16 12:17, David Malcolm wrote: How about splitting out the bail-out code into a separate function: diagnostic_handle_max_errors Having discovered how fortran buffers errors, I think this approach is necessary. I think I'm going to be in assignment-limbo for a little while though

Re: fix -fmax-errors & notes

2016-10-15 Thread Nathan Sidwell
On 10/15/16 05:31, Andreas Schwab wrote: On Okt 13 2016, Nathan Sidwell wrote: 2016-10-13 Nathan Sidwell * diagnostic.c (diagnostic_action_after_output): Remove max error handling here (diagnostic_report_diagnostic): ... do it here instead. All tests that use

Re: fix -fmax-errors & notes

2016-10-15 Thread Andreas Schwab
On Okt 13 2016, Nathan Sidwell wrote: > 2016-10-13 Nathan Sidwell > > * diagnostic.c (diagnostic_action_after_output): Remove max error > handling here > (diagnostic_report_diagnostic): ... do it here instead. All tests that use -fmax-errors now cause the compiler to cr

Re: fix -fmax-errors & notes

2016-10-14 Thread David Malcolm
On Fri, 2016-10-14 at 15:50 -0400, Nathan Sidwell wrote: > On 10/14/16 15:17, David Malcolm wrote: > > > "Limits the maximum number of error messages to @var{n}, at which > > point > > GCC bails out rather than attempting to continue processing the > > source > > code. If @var{n} is 0 (the defaul

Re: fix -fmax-errors & notes

2016-10-14 Thread Nathan Sidwell
On 10/14/16 15:17, David Malcolm wrote: "Limits the maximum number of error messages to @var{n}, at which point GCC bails out rather than attempting to continue processing the source code. If @var{n} is 0 (the default), there is no limit on the number of error messages produced. If @option{-Wf

Re: fix -fmax-errors & notes

2016-10-14 Thread David Malcolm
On Thu, 2016-10-13 at 06:48 -0400, Nathan Sidwell wrote: > On 10/11/16 16:07, David Malcolm wrote: > > > This logic is running when the next diagnostic is about to be > > emitted. > > But what if the user has selected -Wfatal-errors and there's a > > single > > error and no further diagnostics? C

Re: fix -fmax-errors & notes

2016-10-13 Thread Nathan Sidwell
On 10/11/16 16:07, David Malcolm wrote: This logic is running when the next diagnostic is about to be emitted. But what if the user has selected -Wfatal-errors and there's a single error and no further diagnostics? Could this change the observable behavior? (I'm trying to think of a case here,

Re: fix -fmax-errors & notes

2016-10-11 Thread Nathan Sidwell
On 10/11/16 16:07, David Malcolm wrote: This logic is running when the next diagnostic is about to be emitted. But what if the user has selected -Wfatal-errors and there's a single error and no further diagnostics? Could this change the observable behavior? (I'm trying to think of a case here,

Re: fix -fmax-errors & notes

2016-10-11 Thread David Malcolm
On Tue, 2016-10-11 at 06:34 -0400, Nathan Sidwell wrote: > Hi, > Jonathan & I were chatting at the cauldron about how -fmax-errors > kills any > notes about the final error. That's because we bail out just after > emitting the > final error. This patch fixes the problem by bailing out just befo