Re: s390: Fix bootstrap -Wformat-diag errors

2022-02-03 Thread Martin Sebor via Gcc-patches
On 2/3/22 09:45, Martin Liška wrote: On 2/3/22 17:43, Martin Sebor wrote: On 2/3/22 01:59, Martin Liška wrote: On 2/3/22 09:24, Robin Dapp via Gcc-patches wrote: Hi Martin, Either this:     error ("% is unknown", orig_p); or this would be better:     error ("attribute % is unknown",

Re: s390: Fix bootstrap -Wformat-diag errors

2022-02-03 Thread Martin Liška
On 2/3/22 17:43, Martin Sebor wrote: On 2/3/22 01:59, Martin Liška wrote: On 2/3/22 09:24, Robin Dapp via Gcc-patches wrote: Hi Martin, Either this:     error ("% is unknown", orig_p); or this would be better:     error ("attribute % is unknown", orig_p); The %< %> directives will render

Re: s390: Fix bootstrap -Wformat-diag errors

2022-02-03 Thread Martin Sebor via Gcc-patches
On 2/3/22 01:59, Martin Liška wrote: On 2/3/22 09:24, Robin Dapp via Gcc-patches wrote: Hi Martin, Either this:     error ("% is unknown", orig_p); or this would be better:     error ("attribute % is unknown", orig_p); The %< %> directives will render it in single quotes like keywords and

Re: s390: Fix bootstrap -Wformat-diag errors

2022-02-03 Thread Martin Liška
On 2/3/22 09:24, Robin Dapp via Gcc-patches wrote: Hi Martin, Either this: error ("% is unknown", orig_p); or this would be better: error ("attribute % is unknown", orig_p); The %< %> directives will render it in single quotes like keywords and identifiers. Using %qs would render

Re: s390: Fix bootstrap -Wformat-diag errors

2022-02-03 Thread Robin Dapp via Gcc-patches
Hi Martin, > Either this: > >error ("% is unknown", orig_p); > > or this would be better: > >error ("attribute % is unknown", orig_p); > > The %< %> directives will render it in single quotes like keywords and > identifiers. Using %qs would render it in double quotes like a string, >

Re: s390: Fix bootstrap -Wformat-diag errors

2022-02-02 Thread Martin Sebor via Gcc-patches
On 2/2/22 09:35, Robin Dapp via Gcc-patches wrote: Hi, this fixes the s390 bootstrap errors caused by -Werror=format-diag. It simply splits the problematic format strings. Either this: error ("% is unknown", orig_p); or this would be better: error ("attribute % is unknown", orig_p);