Re: Re-factor tree.h - Part 1

2013-11-07 Thread Jeff Law
On 11/07/13 10:24, Diego Novillo wrote: On Thu, Nov 7, 2013 at 5:29 AM, Richard Biener wrote: Moved to fold-const.c: size_low_cst Same as int_cst_value just with lack of any checking? It may be. It's used by the POINTER_EXPR_PLUS handler. I will try to replace it in a later patch.

Re: Re-factor tree.h - Part 1

2013-11-07 Thread Richard Biener
On Wed, Nov 6, 2013 at 6:10 PM, Diego Novillo wrote: > On Wed, Nov 6, 2013 at 2:04 AM, Marc Glisse wrote: >> On Tue, 5 Nov 2013, Diego Novillo wrote: >> >>> This is the first patch in a series of patches to cleanup tree.h to >>> reduce the exposure it has all over the compiler. >>> >>> In this pa

Re: Re-factor tree.h - Part 1

2013-11-06 Thread Jeff Law
On 11/05/13 20:22, Diego Novillo wrote: This is the first patch in a series of patches to cleanup tree.h to reduce the exposure it has all over the compiler. [ ... ] Additionally, the patch removes functions that were never used. This part should just go forward and should be considered pre-a

Re: Re-factor tree.h - Part 1

2013-11-06 Thread Diego Novillo
On Wed, Nov 6, 2013 at 11:54 AM, Jeff Law wrote: > On 11/06/13 00:04, Marc Glisse wrote: >> >> On Tue, 5 Nov 2013, Diego Novillo wrote: >> >>> This is the first patch in a series of patches to cleanup tree.h to >>> reduce the exposure it has all over the compiler. >>> >>> In this patch, I'm moving

Re: Re-factor tree.h - Part 1

2013-11-06 Thread Diego Novillo
On Wed, Nov 6, 2013 at 2:04 AM, Marc Glisse wrote: > On Tue, 5 Nov 2013, Diego Novillo wrote: > >> This is the first patch in a series of patches to cleanup tree.h to >> reduce the exposure it has all over the compiler. >> >> In this patch, I'm moving functions that are used once into the files >>

Re: Re-factor tree.h - Part 1

2013-11-06 Thread Jeff Law
On 11/06/13 00:04, Marc Glisse wrote: On Tue, 5 Nov 2013, Diego Novillo wrote: This is the first patch in a series of patches to cleanup tree.h to reduce the exposure it has all over the compiler. In this patch, I'm moving functions that are used once into the files that use them, and make the

Re: Re-factor tree.h - Part 1

2013-11-05 Thread Jakub Jelinek
On Wed, Nov 06, 2013 at 08:04:51AM +0100, Marc Glisse wrote: > On Tue, 5 Nov 2013, Diego Novillo wrote: > > >This is the first patch in a series of patches to cleanup tree.h to > >reduce the exposure it has all over the compiler. > > > >In this patch, I'm moving functions that are used once into t

Re: Re-factor tree.h - Part 1

2013-11-05 Thread Marc Glisse
On Tue, 5 Nov 2013, Diego Novillo wrote: This is the first patch in a series of patches to cleanup tree.h to reduce the exposure it has all over the compiler. In this patch, I'm moving functions that are used once into the files that use them, and make them private to that file. These functions