Re: Fix offloading machine mode stream reading (was: Regression in target MIC compiler)

2015-08-07 Thread Richard Biener
Ok. Richard. On 8/6/15, Thomas Schwinge tho...@codesourcery.com wrote: Hi! On Wed, 5 Aug 2015 15:10:40 +0100, David Sherwood david.sherw...@arm.com wrote: In lto_input_mode_table there is the following line of code: machine_mode inner = (machine_mode) table[bp_unpack_value (bp, 8)]; Is

Fix offloading machine mode stream reading (was: Regression in target MIC compiler)

2015-08-06 Thread Thomas Schwinge
Hi! On Wed, 5 Aug 2015 15:10:40 +0100, David Sherwood david.sherw...@arm.com wrote: In lto_input_mode_table there is the following line of code: machine_mode inner = (machine_mode) table[bp_unpack_value (bp, 8)]; Is this right? In lto_write_mode_table this inner mode is written out

Re: Regression in target MIC compiler

2015-08-05 Thread Thomas Schwinge
Hi! It seems as if David's »[PATCH][1/N] Change GET_MODE_INNER to always return a non-void mode« is relevant here: On Tue, 4 Aug 2015 16:06:23 +0300, Ilya Verbin iver...@gmail.com wrote: On Tue, Aug 04, 2015 at 14:35:11 +0200, Thomas Schwinge wrote: On Fri, 31 Jul 2015 20:13:02 +0300, Ilya

RE: Regression in target MIC compiler

2015-08-05 Thread David Sherwood
Hi Thomas, If this looks like my fault I am happy to look into this and fix the bug if you can tell me how to reproduce it. I recently changed GET_MODE_INNER (m) to return 'm' itself if there is no inner mode and I thought I'd fixed up lto, but it seems I got it wrong. It also sounds like there

RE: Regression in target MIC compiler

2015-08-05 Thread Thomas Schwinge
Hi! On Wed, 5 Aug 2015 11:18:32 +0100, David Sherwood david.sherw...@arm.com wrote: If this looks like my fault Well, not necessarily your fault -- might as well just be something that has already been lurking in gcc/lto-streamer-in.c:lto_input_mode_table, but so far we've gotten away without

RE: Regression in target MIC compiler

2015-08-05 Thread David Sherwood
@gcc.gnu.org; Kirill Yukhin; nat...@codesourcery.com; Richard Sandiford; Ilya Verbin; Jeff Law Subject: RE: Regression in target MIC compiler Hi! On Wed, 5 Aug 2015 11:18:32 +0100, David Sherwood david.sherw...@arm.com wrote: If this looks like my fault Well, not necessarily your fault

RE: Regression in target MIC compiler

2015-08-05 Thread Thomas Schwinge
Hi! On Wed, 5 Aug 2015 15:10:40 +0100, David Sherwood david.sherw...@arm.com wrote: In lto_input_mode_table there is the following line of code: [...] Thanks! That's not exactly it, but you put me on the right track. Testing a patch. Grüße, Thomas pgpvL8b1BSU6F.pgp Description: PGP

Re: Regression in target MIC compiler

2015-08-04 Thread Thomas Schwinge
Hi! Testing some offloading patches for trunk, I'm encountering the same problem already reported here: On Fri, 31 Jul 2015 20:13:02 +0300, Ilya Verbin iver...@gmail.com wrote: On Fri, Jul 31, 2015 at 18:59:59 +0200, Jakub Jelinek wrote: On Fri, Jul 31, 2015 at 07:53:16PM +0300, Ilya Verbin

Re: Regression in target MIC compiler

2015-08-04 Thread Richard Biener
On Tue, Aug 4, 2015 at 3:06 PM, Ilya Verbin iver...@gmail.com wrote: On Tue, Aug 04, 2015 at 14:35:11 +0200, Thomas Schwinge wrote: On Fri, 31 Jul 2015 20:13:02 +0300, Ilya Verbin iver...@gmail.com wrote: On Fri, Jul 31, 2015 at 18:59:59 +0200, Jakub Jelinek wrote: On Wed, Feb 18, 2015 at

Re: Regression in target MIC compiler

2015-08-04 Thread Ilya Verbin
On Tue, Aug 04, 2015 at 16:07:42 +0200, Richard Biener wrote: On Tue, Aug 4, 2015 at 3:06 PM, Ilya Verbin iver...@gmail.com wrote: On Tue, Aug 04, 2015 at 14:35:11 +0200, Thomas Schwinge wrote: On Fri, 31 Jul 2015 20:13:02 +0300, Ilya Verbin iver...@gmail.com wrote: On Fri, Jul 31, 2015 at

Re: Regression in target MIC compiler

2015-08-04 Thread Ilya Verbin
On Tue, Aug 04, 2015 at 14:35:11 +0200, Thomas Schwinge wrote: On Fri, 31 Jul 2015 20:13:02 +0300, Ilya Verbin iver...@gmail.com wrote: On Fri, Jul 31, 2015 at 18:59:59 +0200, Jakub Jelinek wrote: On Wed, Feb 18, 2015 at 11:00:35 +0100, Jakub Jelinek wrote: + /* First search just

Re: Regression in target MIC compiler (was: nvptx offloading patches [3/n], RFD)

2015-07-31 Thread Jakub Jelinek
On Fri, Jul 31, 2015 at 07:53:16PM +0300, Ilya Verbin wrote: On Fri, Jul 31, 2015 at 19:27:58 +0300, Ilya Verbin wrote: I've noticed that target MIC compiler from trunk hangs forever in lto_input_mode_table in this loop, even on simple testcases. On Wed, Feb 18, 2015 at 11:00:35 +0100,

Regression in target MIC compiler (was: nvptx offloading patches [3/n], RFD)

2015-07-31 Thread Ilya Verbin
Hi! I've noticed that target MIC compiler from trunk hangs forever in lto_input_mode_table in this loop, even on simple testcases. On Wed, Feb 18, 2015 at 11:00:35 +0100, Jakub Jelinek wrote: + /* First search just the GET_CLASS_NARROWEST_MODE to wider modes, +if not found, fallback

Re: Regression in target MIC compiler (was: nvptx offloading patches [3/n], RFD)

2015-07-31 Thread Ilya Verbin
On Fri, Jul 31, 2015 at 19:27:58 +0300, Ilya Verbin wrote: I've noticed that target MIC compiler from trunk hangs forever in lto_input_mode_table in this loop, even on simple testcases. On Wed, Feb 18, 2015 at 11:00:35 +0100, Jakub Jelinek wrote: + /* First search just the

Re: Regression in target MIC compiler (was: nvptx offloading patches [3/n], RFD)

2015-07-31 Thread Ilya Verbin
On Fri, Jul 31, 2015 at 18:59:59 +0200, Jakub Jelinek wrote: On Fri, Jul 31, 2015 at 07:53:16PM +0300, Ilya Verbin wrote: On Fri, Jul 31, 2015 at 19:27:58 +0300, Ilya Verbin wrote: I've noticed that target MIC compiler from trunk hangs forever in lto_input_mode_table in this loop, even on