Re: Revert DECL_USER_ALIGN part of r241959

2018-01-05 Thread Jakub Jelinek
On Fri, Jan 05, 2018 at 10:25:35AM +, Richard Sandiford wrote: > Jakub Jelinek writes: > > On Fri, Jan 05, 2018 at 09:49:56AM +, Richard Sandiford wrote: > >> Is the patch OK as a compromise for GCC 8? We don't speculatively > >> increase the user alignment in

Re: Revert DECL_USER_ALIGN part of r241959

2018-01-05 Thread Richard Sandiford
Jakub Jelinek writes: > On Fri, Jan 05, 2018 at 09:49:56AM +, Richard Sandiford wrote: >> Is the patch OK as a compromise for GCC 8? We don't speculatively >> increase the user alignment in increase_alignment, but do still increase >> it if it helps to vectorise a

Re: Revert DECL_USER_ALIGN part of r241959

2018-01-05 Thread Jakub Jelinek
On Fri, Jan 05, 2018 at 09:49:56AM +, Richard Sandiford wrote: > Is the patch OK as a compromise for GCC 8? We don't speculatively > increase the user alignment in increase_alignment, but do still increase > it if it helps to vectorise a particular loop access? I'd be a little bit worried

Re: Revert DECL_USER_ALIGN part of r241959

2018-01-05 Thread Richard Sandiford
Richard Biener writes: > On Fri, Jan 5, 2018 at 9:47 AM, Richard Biener > wrote: >> On Wed, Jan 3, 2018 at 4:06 PM, Richard Sandiford >> wrote: >>> r241959 included code to stop us increasing the alignment of

Re: Revert DECL_USER_ALIGN part of r241959

2018-01-05 Thread Richard Biener
On Fri, Jan 5, 2018 at 9:47 AM, Richard Biener wrote: > On Wed, Jan 3, 2018 at 4:06 PM, Richard Sandiford > wrote: >> r241959 included code to stop us increasing the alignment of a >> "user-aligned" variable. This wasn't the main purpose

Re: Revert DECL_USER_ALIGN part of r241959

2018-01-05 Thread Richard Biener
On Wed, Jan 3, 2018 at 4:06 PM, Richard Sandiford wrote: > r241959 included code to stop us increasing the alignment of a > "user-aligned" variable. This wasn't the main purpose of the patch, > and I think it was just there to make the testcase work. > > The

Revert DECL_USER_ALIGN part of r241959

2018-01-03 Thread Richard Sandiford
r241959 included code to stop us increasing the alignment of a "user-aligned" variable. This wasn't the main purpose of the patch, and I think it was just there to make the testcase work. The documentation for the aligned attribute says: This attribute specifies a minimum alignment for the