Re: Some wide-int review comments

2013-11-27 Thread Richard Biener
On Tue, Nov 26, 2013 at 5:33 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: Richi, patch ping Ok. Thanks, Richard. also two more pieces of information.With further testing, this seems to fix Tests that now work, but didn't before: ===

Re: Some wide-int review comments

2013-11-27 Thread Kenneth Zadeck
committed as revision 205448 to trunk. committed as revision 205455 to wide-int branch. On 11/27/2013 05:50 AM, Richard Biener wrote: On Tue, Nov 26, 2013 at 5:33 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: Richi, patch ping Ok. Thanks, Richard. also two more pieces of information.

Re: Some wide-int review comments

2013-11-26 Thread Kenneth Zadeck
Richi, patch ping also two more pieces of information.With further testing, this seems to fix Tests that now work, but didn't before: === ext/random/hypergeometric_distribution/operators/values.cc (test for excess errors) New tests that PASS:

Re: Some wide-int review comments

2013-11-20 Thread Kenneth Zadeck
On 11/13/2013 04:59 AM, Richard Biener wrote: On Tue, Nov 12, 2013 at 5:43 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/12/2013 11:27 AM, Joseph S. Myers wrote: On Tue, 12 Nov 2013, Kenneth Zadeck wrote: Richi, i am having a little trouble putting this back the way that you

Re: Some wide-int review comments

2013-11-19 Thread Kenneth Zadeck
Committed with all your changes as revision 205049. the only interesting change is the response to your last comment. I changed the frag to: /* Third, unsigned integers with top bit set never fit signed types. */ - if (!TYPE_UNSIGNED (type) sgn_c == UNSIGNED wi::neg_p (c)) -return

Re: Some wide-int review comments

2013-11-18 Thread Richard Sandiford
Thanks for the changes. @@ -8162,7 +8162,7 @@ fold_builtin_logarithm (location_t loc, /* Prepare to do logN(exp10(exponent) - exponent*logN(10). */ { REAL_VALUE_TYPE dconst10; - real_from_integer (dconst10, VOIDmode, 10, SIGNED); +

Re: Some wide-int review comments

2013-11-17 Thread Kenneth Zadeck
On 11/08/2013 05:30 AM, Richard Sandiford wrote: Some comments from looking through the diff with the merge point, ignoring wide-int.h and wide-int.cc. A few more to follow in the form of patchses. dwarf2out.c has: +case CONST_WIDE_INT: + if (mode == VOIDmode) +

Re: Some wide-int review comments

2013-11-15 Thread Kenneth Zadeck
On 11/08/2013 05:30 AM, Richard Sandiford wrote: Some comments from looking through the diff with the merge point, ignoring wide-int.h and wide-int.cc. A few more to follow in the form of patchses. dwarf2out.c has: +case CONST_WIDE_INT: + if (mode == VOIDmode) +

Re: Some wide-int review comments

2013-11-15 Thread Kenneth Zadeck
Please ignore the email i just sent that looks like this.I accidentally pushed the send button. it is not ready yet. kenny On 11/15/2013 12:49 PM, Kenneth Zadeck wrote: On 11/08/2013 05:30 AM, Richard Sandiford wrote: Some comments from looking through the diff with the merge point,

Re: Some wide-int review comments

2013-11-13 Thread Richard Biener
On Tue, Nov 12, 2013 at 5:43 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/12/2013 11:27 AM, Joseph S. Myers wrote: On Tue, 12 Nov 2013, Kenneth Zadeck wrote: Richi, i am having a little trouble putting this back the way that you want. The issue is rem. what is supposed to

Re: Some wide-int review comments

2013-11-13 Thread Richard Sandiford
Kenneth Zadeck zad...@naturalbridge.com writes: From fold-const.c: @@ -13686,14 +13548,17 @@ fold_binary_loc (location_t loc, break; } -else if (TREE_INT_CST_HIGH (arg1) == signed_max_hi - TREE_INT_CST_LOW (arg1) == signed_max_lo +

Re: Some wide-int review comments

2013-11-12 Thread Kenneth Zadeck
Richi, i am having a little trouble putting this back the way that you want. The issue is rem. what is supposed to happen for INT_MIN % -1? I would assume because i am failing the last case of gcc.dg/c90-const-expr-8.c that INT_MIN %-1 should not overflow even if INT_MIN / -1 does.

Re: Some wide-int review comments

2013-11-12 Thread Joseph S. Myers
On Tue, 12 Nov 2013, Kenneth Zadeck wrote: Richi, i am having a little trouble putting this back the way that you want. The issue is rem. what is supposed to happen for INT_MIN % -1? I would assume because i am failing the last case of gcc.dg/c90-const-expr-8.c that INT_MIN %-1 should

Re: Some wide-int review comments

2013-11-12 Thread Kenneth Zadeck
On 11/12/2013 11:27 AM, Joseph S. Myers wrote: On Tue, 12 Nov 2013, Kenneth Zadeck wrote: Richi, i am having a little trouble putting this back the way that you want. The issue is rem. what is supposed to happen for INT_MIN % -1? I would assume because i am failing the last case of

Re: Some wide-int review comments

2013-11-11 Thread Richard Biener
On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/08/2013 05:30 AM, Richard Sandiford wrote: From tree-vrp.c: @@ -1893,6 +1884,10 @@ vrp_int_const_binop (enum tree_code code /* If the singed operation wraps then int_const_binop has done

Re: Some wide-int review comments

2013-11-11 Thread Kenneth Zadeck
On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/08/2013 05:30 AM, Richard Sandiford wrote: From tree-vrp.c: @@ -1893,6 +1884,10 @@ vrp_int_const_binop (enum tree_code code /* If the singed operation

Re: Some wide-int review comments

2013-11-11 Thread Richard Biener
On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/08/2013 05:30 AM, Richard Sandiford wrote: From tree-vrp.c: @@ -1893,6

Re: Some wide-int review comments

2013-11-11 Thread Kenneth Zadeck
On 11/11/2013 09:42 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/08/2013 05:30 AM, Richard Sandiford

Re: Some wide-int review comments

2013-11-11 Thread Richard Biener
On Mon, Nov 11, 2013 at 4:04 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/11/2013 09:42 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM,

Re: Some wide-int review comments

2013-11-11 Thread Kenneth Zadeck
On 11/11/2013 10:04 AM, Kenneth Zadeck wrote: On 11/11/2013 09:42 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck zad...@naturalbridge.com

Re: Some wide-int review comments

2013-11-11 Thread Kenneth Zadeck
On 11/11/2013 10:29 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 4:04 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/11/2013 09:42 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 11/11/2013 06:49 AM, Richard Biener

Re: Some wide-int review comments

2013-11-09 Thread Kenneth Zadeck
On 11/08/2013 05:30 AM, Richard Sandiford wrote: Some comments from looking through the diff with the merge point, ignoring wide-int.h and wide-int.cc. A few more to follow in the form of patchses. dwarf2out.c has: +case CONST_WIDE_INT: + if (mode == VOIDmode) +

Some wide-int review comments

2013-11-08 Thread Richard Sandiford
Some comments from looking through the diff with the merge point, ignoring wide-int.h and wide-int.cc. A few more to follow in the form of patchses. dwarf2out.c has: +case CONST_WIDE_INT: + if (mode == VOIDmode) + mode = GET_MODE (rtl); + + if (mode !=

Re: Some wide-int review comments

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 2:30 AM, Richard Sandiford rdsandif...@googlemail.com wrote: From gcse.c: --- wide-int-base/gcc/gcc/gcse.c 2013-11-05 13:09:32.148376180 + +++ wide-int/gcc/gcc/gcse.c 2013-11-05 13:07:28.431495118 + @@ -1997,6 +1997,13 @@ prune_insertions_deletions (int