Re: Type comparing TLC

2015-03-10 Thread Ilya Verbin
Hi! On Fri, Feb 20, 2015 at 19:49:03 +0100, Jan Hubicka wrote: On Fri, Feb 20, 2015 at 02:15:24PM +0100, Thomas Schwinge wrote: * ipa-devirt.c (odr_subtypes_equivalent_p): Fix formating. (compare_virtual_tables): Be smarter about skipping typeinfos; do sane

Re: Type comparing TLC

2015-03-10 Thread Jan Hubicka
Hi! On Fri, Feb 20, 2015 at 19:49:03 +0100, Jan Hubicka wrote: On Fri, Feb 20, 2015 at 02:15:24PM +0100, Thomas Schwinge wrote: * ipa-devirt.c (odr_subtypes_equivalent_p): Fix formating. (compare_virtual_tables): Be smarter about skipping typeinfos; do sane

Re: Type comparing TLC

2015-02-20 Thread Thomas Schwinge
Hi! On Wed, 18 Feb 2015 17:17:08 +0100, Jan Hubicka hubi...@ucw.cz wrote: looking across the ODR violation messages in libreoffice and Chromium I found some false positives and some confused messages. This patch fixes them. In partiuclar - I introduced nasty vtable corruption when breaking

Re: Type comparing TLC

2015-02-20 Thread Jakub Jelinek
On Fri, Feb 20, 2015 at 02:15:24PM +0100, Thomas Schwinge wrote: * ipa-devirt.c (odr_subtypes_equivalent_p): Fix formating. (compare_virtual_tables): Be smarter about skipping typeinfos; do sane output on virtual table table mismatch. (warn_odr): Be ready for forward

Re: Type comparing TLC

2015-02-20 Thread Jan Hubicka
On Fri, Feb 20, 2015 at 02:15:24PM +0100, Thomas Schwinge wrote: * ipa-devirt.c (odr_subtypes_equivalent_p): Fix formating. (compare_virtual_tables): Be smarter about skipping typeinfos; do sane output on virtual table table mismatch. (warn_odr): Be ready for forward

Type comparing TLC

2015-02-18 Thread Jan Hubicka
Hi, looking across the ODR violation messages in libreoffice and Chromium I found some false positives and some confused messages. This patch fixes them. In partiuclar - I introduced nasty vtable corruption when breaking out my type merging patches, so we ended up creating separate entries