Re: Use predicates for RTL objects

2019-08-08 Thread Arvind Sankar
On Thu, Aug 08, 2019 at 10:42:06AM -0600, Jeff Law wrote: > On 8/5/19 12:29 PM, Segher Boessenkool wrote: > > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > >> On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > >>> First: do you have a copyright assignment?

Re: Use predicates for RTL objects

2019-08-08 Thread Segher Boessenkool
On Thu, Aug 08, 2019 at 10:42:06AM -0600, Jeff Law wrote: > On 8/5/19 12:29 PM, Segher Boessenkool wrote: > > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > >> On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > >>> First: do you have a copyright assignment?

Re: Use predicates for RTL objects

2019-08-08 Thread Jakub Jelinek
On Thu, Aug 08, 2019 at 10:42:06AM -0600, Jeff Law wrote: > -/* Predicate yielding true iff X is an rtx for a double-int. */ > +/* Predicate yielding true iff X is an rtx for a floating point > constant. */ > #define CONST_DOUBLE_AS_FLOAT_P(X) \ > (GET_CODE (X) ==

Re: Use predicates for RTL objects

2019-08-08 Thread Jeff Law
On 8/5/19 12:29 PM, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: >> On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: >>> First: do you have a copyright assignment? See >>> https://gcc.gnu.org/contribute.html >>> for instructions.

Re: Use predicates for RTL objects

2019-08-05 Thread Arvind Sankar
Here's the patches split up. The ones that say autogenerated were generated from the script below. I haven't included that as a patch yet since not sure about the copyright/licensing boilerplate to insert in it. contrib/rtl-pred.sh: #!/bin/sh #

Re: Use predicates for RTL objects

2019-08-05 Thread Arvind Sankar
On Mon, Aug 05, 2019 at 01:29:26PM -0500, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > > > -/* Predicate yielding true iff X is an rtx for a double-int. */ > > > > +/*

Re: Use predicates for RTL objects

2019-08-05 Thread Segher Boessenkool
On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > First: do you have a copyright assignment? See > > https://gcc.gnu.org/contribute.html > > for instructions. > > Nope, is this really substantial enough to

Re: Use predicates for RTL objects

2019-08-05 Thread Arvind Sankar
On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > Hi Arvind, > > First: do you have a copyright assignment? See > https://gcc.gnu.org/contribute.html > for instructions. Nope, is this really substantial enough to warrant one? > > This is easier to review, and even to

Re: Use predicates for RTL objects

2019-08-05 Thread Segher Boessenkool
Hi Arvind, First: do you have a copyright assignment? See https://gcc.gnu.org/contribute.html for instructions. This is easier to review, and even to commit as obvious, if you did a patch per macro, certainly for the new macros; and, put the script in contrib/, and then say with every patch

Re: Use predicates for RTL objects

2019-08-02 Thread Segher Boessenkool
On Fri, Aug 02, 2019 at 01:55:04PM -0400, Arvind Sankar wrote: > On Fri, Aug 02, 2019 at 12:49:56PM -0500, Segher Boessenkool wrote: > > On Fri, Aug 02, 2019 at 01:38:21PM -0400, Arvind Sankar wrote: > > > Hi, I have taken a crack at the beginner GCC project mentioned at > > >

Re: Use predicates for RTL objects

2019-08-02 Thread Arvind Sankar
On Fri, Aug 02, 2019 at 12:49:56PM -0500, Segher Boessenkool wrote: > On Fri, Aug 02, 2019 at 01:38:21PM -0400, Arvind Sankar wrote: > > Hi, I have taken a crack at the beginner GCC project mentioned at > > https://gcc.gnu.org/projects/beginner.html to replace uses of GET_CODE > > to check

Re: Use predicates for RTL objects

2019-08-02 Thread Segher Boessenkool
On Fri, Aug 02, 2019 at 01:38:21PM -0400, Arvind Sankar wrote: > Hi, I have taken a crack at the beginner GCC project mentioned at > https://gcc.gnu.org/projects/beginner.html to replace uses of GET_CODE > to check rtx_code with the appropriate predicate macros. > > Would someone be able to