Re: V4 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-26 Thread Martin Liška
On 5/25/20 7:42 PM, H.J. Lu wrote: Here is the updated patch. OK for master? Thank you for the updated patch. I have still few nits: 1) I would make all the: + has_sse3 = has_feature (FEATURE_SSE3); a macro. The local variable seems to superfluous. 2) can we automatically deduce

V4 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-25 Thread H.J. Lu via Gcc-patches
On Mon, May 25, 2020 at 2:52 AM Martin Liška wrote: > > Hello. > > I really welcome the unification patch and I have some comments (ideas): > > 1) > > > +static inline int > > +has_cpu_feature (struct __processor_model *cpu_model, > > + unsigned int *cpu_features2, > > +