Re: fdiagnostics-color=never does not disable color for some diagnostics

2015-09-24 Thread Jason Merrill
On 09/22/2015 04:23 PM, Manuel López-Ibáñez wrote: +error_at (loc, "-Werror=%s: no option -%s", arg, new_option); + else if (!(cl_options[option_index].flags & CL_WARNING)) +error_at (loc, "-Werror=%s: -%s is not an option that controls warnings", Won't these incorrectly start with

Re: fdiagnostics-color=never does not disable color for some diagnostics

2015-09-24 Thread Jason Merrill
On 09/24/2015 11:32 AM, Manuel López-Ibáñez wrote: On 24 September 2015 at 15:06, Jason Merrill wrote: On 09/22/2015 04:23 PM, Manuel López-Ibáñez wrote: +error_at (loc, "-Werror=%s: no option -%s", arg, new_option); + else if (!(cl_options[option_index].flags &

Re: fdiagnostics-color=never does not disable color for some diagnostics

2015-09-24 Thread Manuel López-Ibáñez
On 24 September 2015 at 15:06, Jason Merrill wrote: > On 09/22/2015 04:23 PM, Manuel López-Ibáñez wrote: >> >> +error_at (loc, "-Werror=%s: no option -%s", arg, new_option); >> + else if (!(cl_options[option_index].flags & CL_WARNING)) >> +error_at (loc, "-Werror=%s:

fdiagnostics-color=never does not disable color for some diagnostics

2015-09-22 Thread Manuel López-Ibáñez
Actually, I was trying to reject non-warning options as argument to -Werror=. However, the new test fails because -fdiagnostics-color=never is always placed by the driver after the warning options when calling the compiler proper. This patch prunes all -fdiagnostics-color from the command-line but