Re: functional and type_traits cleanup

2013-04-07 Thread François Dumont
On 04/06/2013 10:43 PM, Jonathan Wakely wrote: That wouldn't hurt, but I agree it shouldn't prevent the patch going in. François, please go ahead and commit it, thanks. Attached patch applied then. Not exactly the one submitted the 2nd time because I hadn't fix dg-error line numbers at that

Re: functional and type_traits cleanup

2013-04-06 Thread Jonathan Wakely
On 5 April 2013 21:12, François Dumont wrote: In fact my first attempt was a very simple one: templatetypename _From, typename _To class __is_convertible_helper_From, _To, false { templatetypename _To1 static true_type __test(_To1); templatetypename

Re: functional and type_traits cleanup

2013-04-06 Thread Daniel Krügler
2013/4/6 Jonathan Wakely jwakely@gmail.com But the version with the default template parameter is fine and more consistent with the other helpers implementation so, adopted! Here is an other version of the patch for validation. Daniel, I agree that inheritance with

Re: functional and type_traits cleanup

2013-04-06 Thread Jonathan Wakely
On 6 April 2013 21:03, Daniel Krügler wrote: 2013/4/6 Jonathan Wakely jwakely@gmail.com But the version with the default template parameter is fine and more consistent with the other helpers implementation so, adopted! Here is an other version of the patch for validation.

Re: functional and type_traits cleanup

2013-04-06 Thread Paolo Carlini
Hi, On 04/06/2013 10:43 PM, Jonathan Wakely wrote: My response was more like a general comment: My apprehension is that I after these changes not all predicate type traits do satisfy the Library requirement anymore that they still derive from std::integral_constant. But I have not checked that

Re: functional and type_traits cleanup

2013-04-05 Thread François Dumont
On 04/05/2013 12:20 AM, Jonathan Wakely wrote: On 4 April 2013 21:16, François Dumont wrote: I think this is mostly very good, thanks for cleaning it up. The indentiation of the closing brace for __is_assignable_helper looks wrong. Is there a reason that __is_assignable_helper::__test uses a