Hi Matthew,
I see you pushed this based on Sandra's feedback and Richard's approval
(which is fine).
As a practical note, instead of
* doc/tm.texi: Regenerated.
* target.def (function_attribute_inlinable_p,
unspec_may_trap_p): Update documentation.
I'd use
On Mon, 1 Jul 2024, Matthew Malcomson wrote:
> Ping plus some extra people on Cc since I wasn't sure who to ask for review.
> (Adding maintainers for `middle-end` plus Richard S).
>
> N.b. I'd update the cover-letter to also mention that no existing
> implementation of `function_attribute_inlinab
On 7/1/24 11:39, Matthew Malcomson wrote:
Ping plus some extra people on Cc since I wasn't sure who to ask for
review.
(Adding maintainers for `middle-end` plus Richard S).
gcc/ChangeLog:
* doc/tm.texi (function_attribute_inlinable_p,
unspec_may_trap_p): Update documentation.
* t
Ping plus some extra people on Cc since I wasn't sure who to ask for review.
(Adding maintainers for `middle-end` plus Richard S).
N.b. I'd update the cover-letter to also mention that no existing
implementation of `function_attribute_inlinable_p` uses "the current
function" in any way.
On 4
The `function_attribute_inlinable_p` hook documentation described it
returning the value if it is OK to inline the provided fndecl into "the
current function". AFAICS This hook is only called when
`current_function_decl` is the same as the `fndecl` argument that the
hook is given, hence asking whe
