Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-26 Thread Ian Lance Taylor
On Wed, Dec 26, 2018 at 7:39 AM Cherry Zhang wrote: > > Finally I found an ARM machine and was able to build ARM32 gcc on it, and > reproduced the failures. The Go programs aborted, in parse_lsda_header, > called from probestackmaps in the runtime startup. It seems that >

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-26 Thread Cherry Zhang via gcc-patches
Finally I found an ARM machine and was able to build ARM32 gcc on it, and reproduced the failures. The Go programs aborted, in parse_lsda_header, called from probestackmaps in the runtime startup. It seems that _Unwind_GetLanguageSpecificData doesn't return a valid LSDA when called from a callback

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-18 Thread Matthias Klose
Cherry, see https://gcc.gnu.org/ml/gcc-testresults/2018-12/msg02241.html https://gcc.gnu.org/ml/gcc-testresults/2018-12/msg02240.html still shows ~180 test failures on ARM32. Sorry, no access to an ARM32 box until next year. Matthias On 13.12.18 00:27, Ian Lance Taylor wrote: > On Wed, Dec 12,

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-12 Thread Ian Lance Taylor
On Wed, Dec 12, 2018 at 8:10 AM Cherry Zhang wrote: > > Thank you, Matthias! > > From the log, essentially all the tests aborted. The only place the new code > can cause abort on all programs that I can think of is in the runtime startup > code, probestackmaps, which calls value_size, which

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-12 Thread Cherry Zhang via gcc-patches
Thank you, Matthias! >From the log, essentially all the tests aborted. The only place the new code can cause abort on all programs that I can think of is in the runtime startup code, probestackmaps, which calls value_size, which aborts due to an unhandled case. I haven't been able to try out on

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-11 Thread Matthias Klose
On 11.12.18 22:01, Cherry Zhang wrote: > On Tue, Dec 11, 2018 at 3:51 PM Ian Lance Taylor wrote: > >> On Tue, Dec 11, 2018 at 6:52 AM Matthias Klose wrote: >>> >>> On 10.12.18 16:54, Cherry Zhang wrote: On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose >> wrote: > On 06.12.18 00:09,

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-11 Thread Cherry Zhang via gcc-patches
On Tue, Dec 11, 2018 at 3:51 PM Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 6:52 AM Matthias Klose wrote: > > > > On 10.12.18 16:54, Cherry Zhang wrote: > > > On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose > wrote: > > > > > >> On 06.12.18 00:09, Ian Lance Taylor wrote: > > >>> This

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-11 Thread Ian Lance Taylor
On Tue, Dec 11, 2018 at 6:52 AM Matthias Klose wrote: > > On 10.12.18 16:54, Cherry Zhang wrote: > > On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose wrote: > > > >> On 06.12.18 00:09, Ian Lance Taylor wrote: > >>> This libgo patch by Cherry Zhang adds support for precise stack > >>> scanning to

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-11 Thread Matthias Klose
On 10.12.18 16:54, Cherry Zhang wrote: > On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose wrote: > >> On 06.12.18 00:09, Ian Lance Taylor wrote: >>> This libgo patch by Cherry Zhang adds support for precise stack >>> scanning to the Go runtime. This uses per-function stack maps stored >>> in the

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-10 Thread Cherry Zhang via gcc-patches
On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose wrote: > On 06.12.18 00:09, Ian Lance Taylor wrote: > > This libgo patch by Cherry Zhang adds support for precise stack > > scanning to the Go runtime. This uses per-function stack maps stored > > in the exception tables in the language-specific

Re: libgo patch committed: Add precise stack scan support

2018-12-09 Thread Matthias Klose
On 06.12.18 00:09, Ian Lance Taylor wrote: > This libgo patch by Cherry Zhang adds support for precise stack > scanning to the Go runtime. This uses per-function stack maps stored > in the exception tables in the language-specific data area. The > compiler needs to generate these stack maps;

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-07 Thread Cherry Zhang via gcc-patches
Sorry about the breakage. Thanks for the patch. On Fri, Dec 7, 2018 at 9:23 AM Ian Lance Taylor wrote: > On Fri, Dec 7, 2018 at 2:07 AM Rainer Orth > wrote: > > > > > This libgo patch by Cherry Zhang adds support for precise stack > > > scanning to the Go runtime. This uses per-function

Re: libgo patch committed: Add precise stack scan support

2018-12-07 Thread Ian Lance Taylor
On Fri, Dec 7, 2018 at 2:07 AM Rainer Orth wrote: > > > This libgo patch by Cherry Zhang adds support for precise stack > > scanning to the Go runtime. This uses per-function stack maps stored > > in the exception tables in the language-specific data area. The > > compiler needs to generate

Re: libgo patch committed: Add precise stack scan support

2018-12-07 Thread Rainer Orth
Hi Ian, > This libgo patch by Cherry Zhang adds support for precise stack > scanning to the Go runtime. This uses per-function stack maps stored > in the exception tables in the language-specific data area. The > compiler needs to generate these stack maps; currently this is only > done by a

libgo patch committed: Add precise stack scan support

2018-12-05 Thread Ian Lance Taylor
This libgo patch by Cherry Zhang adds support for precise stack scanning to the Go runtime. This uses per-function stack maps stored in the exception tables in the language-specific data area. The compiler needs to generate these stack maps; currently this is only done by a version of LLVM, not