Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-17 Thread Yvan Roux
On 17 December 2013 00:03, Vladimir Makarov vmaka...@redhat.com wrote: On 12/13/2013, 8:07 AM, Yvan Roux wrote: Thanks for your help Vlad. Another bad news about this PR fix, is that it has resurrected the thumb_movhi_clobber bug (PR 58785) but in a different manner as the original failing

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-16 Thread Vladimir Makarov
On 12/13/2013, 8:07 AM, Yvan Roux wrote: Thanks for your help Vlad. Another bad news about this PR fix, is that it has resurrected the thumb_movhi_clobber bug (PR 58785) but in a different manner as the original failing testcase still pass. I attached a testcase to be compiled with : cc1

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-13 Thread Yvan Roux
Thanks for your help Vlad. Another bad news about this PR fix, is that it has resurrected the thumb_movhi_clobber bug (PR 58785) but in a different manner as the original failing testcase still pass. I attached a testcase to be compiled with : cc1 -mthumb -mcpu=cortex-m0 -O2 m.c And Thumb

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-12 Thread Vladimir Makarov
On 12/11/2013, 1:59 PM, Yvan Roux wrote: On 11 December 2013 19:25, Vladimir Makarov vmaka...@redhat.com wrote: On 12/11/2013, 5:35 AM, Yvan Roux wrote: Hi Vladimir, I've some regressions on ARM after this SP elimination patch, and they are execution failures. Here is the list:

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-11 Thread Yvan Roux
Hi Vladimir, I've some regressions on ARM after this SP elimination patch, and they are execution failures. Here is the list: g++.dg/cilk-plus/AN/array_test_ND_tplt.cc -O3 -fcilkplus gcc.c-torture/execute/va-arg-22.c -O2 gcc.dg/atomic/c11-atomic-exec-5.c -O0 gfortran.dg/direct_io_12.f90

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-11 Thread Ramana Radhakrishnan
Yvan, On Wed, Dec 11, 2013 at 10:35 AM, Yvan Roux yvan.r...@linaro.org wrote: Hi Vladimir, I've some regressions on ARM after this SP elimination patch, and they are execution failures. Here is the list: Pragmatically, I think it's time we turned LRA on by default now that we are in stage3

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-11 Thread Yvan Roux
Pragmatically, I think it's time we turned LRA on by default now that we are in stage3 and that would help with getting more issues out of the auto-testers quicker than anything else. Given we are now well into stage3, we should make sure that the LRA support gets as much testing as it can

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-11 Thread Vladimir Makarov
On 12/11/2013, 5:35 AM, Yvan Roux wrote: Hi Vladimir, I've some regressions on ARM after this SP elimination patch, and they are execution failures. Here is the list: g++.dg/cilk-plus/AN/array_test_ND_tplt.cc -O3 -fcilkplus gcc.c-torture/execute/va-arg-22.c -O2

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-03 Thread Marcus Shawcroft
On 2 December 2013 23:44, Vladimir Makarov vmaka...@redhat.com wrote: If somebody with the rights approves, I can commit it tomorrow. 2013-12-02 Vladimir Makarov vmaka...@redhat.com * config/aarch64/aarch64.c (aarch64_frame_pointer_required): Check LR_REGNUM.

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-03 Thread Vladimir Makarov
On 12/3/2013, 6:54 AM, Marcus Shawcroft wrote: On 2 December 2013 23:44, Vladimir Makarov vmaka...@redhat.com wrote: If somebody with the rights approves, I can commit it tomorrow. 2013-12-02 Vladimir Makarov vmaka...@redhat.com * config/aarch64/aarch64.c

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-02 Thread Vladimir Makarov
On 12/1/2013, 7:57 AM, James Greenhalgh wrote: On Thu, Nov 28, 2013 at 10:11:26PM +, Vladimir Makarov wrote: Committed as rev. 205498. 2013-11-28 Vladimir Makarovvmaka...@redhat.com PR target/57293 * ira.h (ira_setup_eliminable_regset): Remove parameter. *

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-02 Thread Vladimir Makarov
On 12/1/2013, 7:57 AM, James Greenhalgh wrote: On Thu, Nov 28, 2013 at 10:11:26PM +, Vladimir Makarov wrote: Committed as rev. 205498. 2013-11-28 Vladimir Makarovvmaka...@redhat.com PR target/57293 * ira.h (ira_setup_eliminable_regset): Remove parameter. *

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-02 Thread Jeff Law
On 12/02/13 16:44, Vladimir Makarov wrote: First of all, it is a bad situation for code performance when IRA decides that it can use frame pointer for allocation, and after that LRA/reload decides that frame pointer can not be used and spills all pseudos assigned to FP. The generated code

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-01 Thread James Greenhalgh
On Thu, Nov 28, 2013 at 10:11:26PM +, Vladimir Makarov wrote: Committed as rev. 205498. 2013-11-28 Vladimir Makarovvmaka...@redhat.com PR target/57293 * ira.h (ira_setup_eliminable_regset): Remove parameter. * ira.c (ira_setup_eliminable_regset): Ditto. Add

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-29 Thread H.J. Lu
On Thu, Nov 28, 2013 at 9:18 PM, Vladimir Makarov vmaka...@redhat.com wrote: On 11/28/2013, 7:51 PM, H.J. Lu wrote: On Thu, Nov 28, 2013 at 2:11 PM, Vladimir Makarov vmaka...@redhat.com wrote: The following patch fixes PR57293 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 It is

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-29 Thread Jan Hubicka
There is a comment: FIXME: the flags is incorrectly enabled for amdfam10, Bulldozer, Bobcat and Generic. This is because disabling it causes large regression on mgrid due to IRA limitation leading to unecessary use of the frame pointer in 32bit mode. */ DEF_TUNE

patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-28 Thread Vladimir Makarov
The following patch fixes PR57293 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 It is actually an implementation of missed LRA functionality in reg elimination. Before the patch any explicit change of stack pointer in RTL resulted in necessity to use the frame pointer. The patch has

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-28 Thread H.J. Lu
On Thu, Nov 28, 2013 at 2:11 PM, Vladimir Makarov vmaka...@redhat.com wrote: The following patch fixes PR57293 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 It is actually an implementation of missed LRA functionality in reg elimination. Before the patch any explicit change of stack

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-28 Thread Vladimir Makarov
On 11/28/2013, 7:51 PM, H.J. Lu wrote: On Thu, Nov 28, 2013 at 2:11 PM, Vladimir Makarov vmaka...@redhat.com wrote: The following patch fixes PR57293 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 It is actually an implementation of missed LRA functionality in reg elimination.