Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-03 Thread Richard Biener
On Tue, Apr 2, 2013 at 9:08 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: this time for sure. Almost ... diff --git a/gcc/hwint.c b/gcc/hwint.c index 330b42c..92d54a3 100644 --- a/gcc/hwint.c +++ b/gcc/hwint.c @@ -204,3 +204,35 @@ least_common_multiple (HOST_WIDE_INT a, HOST_WIDE_INT b) {

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-03 Thread Kenneth Zadeck
yes, i had caught that when i merged it in with the patches that used it, is it ok aside from that? kenny On 04/03/2013 05:32 AM, Richard Biener wrote: On Tue, Apr 2, 2013 at 9:08 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: this time for sure. Almost ... diff --git a/gcc/hwint.c

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-03 Thread Richard Biener
On Wed, Apr 3, 2013 at 12:47 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: yes, i had caught that when i merged it in with the patches that used it, is it ok aside from that? Yes. Thanks, Richard. kenny On 04/03/2013 05:32 AM, Richard Biener wrote: On Tue, Apr 2, 2013 at 9:08 PM,

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-03 Thread Kenneth Zadeck
committed as revision 197456 kenny On 04/03/2013 08:05 AM, Richard Biener wrote: On Wed, Apr 3, 2013 at 12:47 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: yes, i had caught that when i merged it in with the patches that used it, is it ok aside from that? Yes. Thanks, Richard. kenny

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-02 Thread Richard Biener
On Sun, Mar 31, 2013 at 7:51 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: richard, I was able to add everything except for the checking asserts.While I think that this is a reasonable idea, it is difficult to add that to a function that is defined in hwint.h because of circular

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-02 Thread Kenneth Zadeck
Richard, did everything that you asked here. bootstrapped and regtested on x86-64. ok to commit? kenny On 04/02/2013 05:38 AM, Richard Biener wrote: On Sun, Mar 31, 2013 at 7:51 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: richard, I was able to add everything except for the

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-02 Thread Richard Biener
On Tue, Apr 2, 2013 at 3:49 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: Richard, did everything that you asked here. bootstrapped and regtested on x86-64. ok to commit? diff --git a/gcc/hwint.c b/gcc/hwint.c index 330b42c..7e5b85c 100644 --- a/gcc/hwint.c +++ b/gcc/hwint.c @@ -204,3

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-04-02 Thread Kenneth Zadeck
this time for sure. kenny On 04/02/2013 10:54 AM, Richard Biener wrote: On Tue, Apr 2, 2013 at 3:49 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: Richard, did everything that you asked here. bootstrapped and regtested on x86-64. ok to commit? diff --git a/gcc/hwint.c b/gcc/hwint.c

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-03-31 Thread Kenneth Zadeck
richard, I was able to add everything except for the checking asserts.While I think that this is a reasonable idea, it is difficult to add that to a function that is defined in hwint.h because of circular includes. I could move this another file (though this appears to be the logical

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-03-28 Thread Kenneth Zadeck
richard, adding the gcc_checking_assert is going to require that i include system.h in hwint.h which seems to cause a loop. while in principle, i agree with the assert, this is going to be a mess. kenny On 03/27/2013 10:13 AM, Richard Biener wrote: On Wed, Feb 27, 2013 at 1:22 AM,

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-03-27 Thread Richard Biener
On Wed, Feb 27, 2013 at 1:22 AM, Kenneth Zadeck zad...@naturalbridge.com wrote: Here is the first of my wide int patches with joseph's comments and the patch rot removed. I would like to get these pre approved for the next stage 1. + int shift = HOST_BITS_PER_WIDE_INT - (prec

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-02-26 Thread Kenneth Zadeck
Here is the first of my wide int patches with joseph's comments and the patch rot removed. I would like to get these pre approved for the next stage 1. On 10/05/2012 08:14 PM, Joseph S. Myers wrote: On Fri, 5 Oct 2012, Kenneth Zadeck wrote: +# define HOST_HALF_WIDE_INT_PRINT h This may