Re: predcom: Refactor more by encapsulating global states

2021-06-24 Thread Kewen.Lin via Gcc-patches
on 2021/6/23 下午3:22, Richard Biener wrote: > On Tue, Jun 22, 2021 at 4:35 AM Kewen.Lin wrote: >> >> Hi Richi and Martin, >> Thanks Richi! One draft (not ready for review) is attached for the further discussion. It follows the idea of RAII-style cleanup. I noticed that

Re: predcom: Refactor more by encapsulating global states

2021-06-24 Thread Kewen.Lin via Gcc-patches
Hi Martin, on 2021/6/23 上午12:14, Martin Sebor wrote: > On 6/21/21 8:35 PM, Kewen.Lin wrote: >> Hi Richi and Martin, >> Thanks Richi!  One draft (not ready for review) is attached for the further discussion.  It follows the idea of RAII-style cleanup.  I noticed that Martin

Re: predcom: Refactor more by encapsulating global states

2021-06-23 Thread Richard Biener via Gcc-patches
On Tue, Jun 22, 2021 at 4:35 AM Kewen.Lin wrote: > > Hi Richi and Martin, > > >> > >> Thanks Richi! One draft (not ready for review) is attached for the further > >> discussion. It follows the idea of RAII-style cleanup. I noticed that > >> Martin suggested stepping forward to make

Re: predcom: Refactor more by encapsulating global states

2021-06-22 Thread Martin Sebor via Gcc-patches
On 6/21/21 8:35 PM, Kewen.Lin wrote: Hi Richi and Martin, Thanks Richi! One draft (not ready for review) is attached for the further discussion. It follows the idea of RAII-style cleanup. I noticed that Martin suggested stepping forward to make tree_predictive_commoning_loop and its

predcom: Refactor more by encapsulating global states

2021-06-21 Thread Kewen.Lin via Gcc-patches
Hi Richi and Martin, >> >> Thanks Richi! One draft (not ready for review) is attached for the further >> discussion. It follows the idea of RAII-style cleanup. I noticed that >> Martin suggested stepping forward to make tree_predictive_commoning_loop >> and its callees into one class (Thanks